From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvH6U-0007ys-7d for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:53:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvH6S-0007x4-CD for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:53:17 -0400 Received: from [199.232.76.173] (port=40507 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvH6S-0007wx-7z for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:53:16 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:33177) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KvH6R-0008Jz-Py for qemu-devel@nongnu.org; Wed, 29 Oct 2008 15:53:16 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging Date: Wed, 29 Oct 2008 20:53:08 +0100 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810291953.09085.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl On Wednesday 29 October 2008, Blue Swirl wrote: > Hi, > > When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse > the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit > one and vice versa. This patch adds a run time sanity check for TCGv > sizes. Would it make more sense to push these down into tcg_gen_op* ? tcg-op.h is already fairly unwieldy. I wonder if it's worth adding TCG_LOW to enable checking on 32-bit hosts. For futureproofing I'd name things FOO_I32 rather than FOO_32. Paul