From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for debugging
Date: Thu, 30 Oct 2008 01:07:41 +0100 [thread overview]
Message-ID: <200810300007.42763.paul@codesourcery.com> (raw)
In-Reply-To: <4908D7A3.7030309@bellard.org>
On Wednesday 29 October 2008, Fabrice Bellard wrote:
> Blue Swirl wrote:
> > Hi,
> >
> > When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse
> > the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit
> > one and vice versa. This patch adds a run time sanity check for TCGv
> > sizes.
> >
> > Because a 32 bit Qemu host does not really use 64 bit TCGvs, the patch
> > is only functional on a 64 bit host. Of course also a pure 32 bit Qemu
> > target is not likely to suffer from TCGv size confusion.
> >
> > Some use cases are not covered yet. Comments?
>
> Theses tests can be done at compile time by introducing the TCGv_i32 and
> TCGv_i64 types. The same can be done with the helpers by using a few
> macros to declare them.
That would also require updating all the target code in translate.c to use
these types. In principle there's no reason why this couldn't be done, but
it'd be a much more invasive change.
AFAIK there's no way of doing compile time inheritance checking in C.
Paul
next prev parent reply other threads:[~2008-10-30 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 19:31 [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging Blue Swirl
2008-10-29 19:53 ` Paul Brook
2008-10-29 20:06 ` Blue Swirl
2008-10-29 20:14 ` Paul Brook
2008-10-29 20:25 ` Blue Swirl
2008-10-29 21:37 ` [Qemu-devel] " Fabrice Bellard
2008-10-30 0:07 ` Paul Brook [this message]
2008-10-30 9:38 ` Fabrice Bellard
2008-11-01 12:00 ` Blue Swirl
2008-11-01 12:59 ` Paul Brook
2008-11-01 16:56 ` Paul Brook
2008-11-01 17:03 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810300007.42763.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).