[Qemu-devel] Re: [PATCH] linux-user, x86: use target_mmap() to allocate idt, gdt and ldt tables

["Kirill A. Shutemov" <kirill@shutemov.name>]

[-- Attachment #1.1: Type: text/plain, Size: 1543 bytes --]

On Sat, Nov 01, 2008 at 10:33:07AM +0100, Jan Kiszka wrote:
> Kirill A. Shutemov wrote:
> > env->*dt.base should fits target address space, so we should use
> > target_mmap to allocate it.
> 
> I just noticed that this bug is still unfixed upstream, was about to
> repost my corresponding patch [1], but then found this even nicer
> approach. Could someone please finally merge a fix?
> 
> Kirill, do you also have a patch for the problem [2] addresses in your
> queue?

No, I don't. But we also can use target_mmap(with my mmap_find_vma()) for
it, I guess. Can you provide any testcase to reproduce the bug?

> 
> Last time I posted my series, Anthony remarked that the role of the
> linux-user maintainer is vacant. My impression is that this is still the
> case while at the same time Kirill is doing quite a good job now getting
> this corner of qemu in shape again...... :->

I'm interested in commit access. I've already asked about it, but I haven't
got any responce.

I've attached ssh-key just in case. ;)

> 
> Jan
> 
> [1] http://permalink.gmane.org/gmane.comp.emulators.qemu/28386
> [2] http://permalink.gmane.org/gmane.comp.emulators.qemu/28385

<skip/>

> > @@ -283,9 +284,8 @@ static void write_dt(void *ptr, unsigned long addr, unsigned long limit,
> >      p[1] = tswap32(e2);
> >  }
> >  
> > +uint64_t *idt_table;
> 
> This should become static...

Updated patch has been sent.


-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #1.2: id_dsa.pub --]
[-- Type: text/plain, Size: 1128 bytes --]

ssh-dss AAAAB3NzaC1kc3MAAAEBAOlkJ0ucchMEy6shLwYplKpRx8RO1WtJbtMsspWDQlMu6X9DnRZZbiBCo5FwSWuHQbGF+cjUEQM9vYezdyz+slmZQ0Dv8eS/8eqQPpUi9QVpiVOWK8JTh/kqUmXjoFf+oiRAvaXhzGz0nWOtqxQimxMVYD3rxHcM44/TztMOI0J1vZVxep86Uw0jgMfEITanJk65xAEo5dQkF6UbQ5eOw7+Y8ZFurjTQ6R2ZNNPB0tc7HyinDdyRzx8gIA7VYC1yLi3UWcX4in2dczFfLDYRlfLW0Jpz/1i22IGC5Iww27ab+CYSxPNFh36Gc1vrC67F9IE2DC7JFhCNl34Bdt3wEE0AAAAVANjSWDGw+eHsj2U1BLVFNWyMisorAAABAQC2c9ey+myRb4wqcPrHwl0CgmL7Ct2fpqYFSHtphQiL0q6PS8t0/wKKnmquOTrnGkiYMbqBY9OyEg9/c9dAHfZsw+Y3/yDhATIJV18nuyX6OV9lGy1O2E7yUrR9AiO4MinG+aERx2QehTwlwPTy2ANO1B54hCVGfv9oThbB2Sb2tqegjvoWRlfzLyXg0xyCPkB9USkRajxbIMvkZ9JYPaQsKGtJIfDqVHL9moJzGdo83UU5vkAJCZDYumOe+PDIGlrpY1z3bl1MhWfggT+eVKxQsrU/rFh7sI0LQ7+ENLSQq6MWxYdNFVUFDrqWJxOc/1FlkgOMnMFFOkRkOFCqSuKyAAABAH21LqMMxYNaJ23nYumWeJHVPbXLMZBCRHX0c9krdnqN67xNI2WPfJ3kD+qs7quiCIlWt5FGopeH9LjDluVBBz/U7aK072BA3fm5kVlgmlZPgktskMysm8D6UhZvDOgfUgP8qofOPXF9kP5mI7mI8RIxHIiOmyCl+2NbAw/p9owyTzPvwd/kMh6O9ImBtLk5TxTFJIUskCmp1rRx/ZqYqXgp8+DGhCGVqIUaiI2KE32ZMlCY9Mp0Eif18UggldRbgITX2xgPuewk496i2MbObT8TF/yHOtXAsnCSdjmRLR556TmiW5g0qQisxs+xyxWeUhN7Cwyz0pYLrNuFngJggUA= kir@localhost.localdomain

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]