From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwDhY-0003XV-NT for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:27:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwDhX-0003XJ-TG for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:27:28 -0400 Received: from [199.232.76.173] (port=49628 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwDhX-0003XF-Mr for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:27:27 -0400 Received: from ey-out-1920.google.com ([74.125.78.145]:33626) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KwDhX-0005ll-2R for qemu-devel@nongnu.org; Sat, 01 Nov 2008 06:27:27 -0400 Received: by ey-out-1920.google.com with SMTP id 4so583728eyk.4 for ; Sat, 01 Nov 2008 03:27:26 -0700 (PDT) Date: Sat, 1 Nov 2008 12:27:23 +0200 From: "Kirill A. Shutemov" Message-ID: <20081101102723.GB26770@localhost.localdomain> References: <1223892640-15545-13-git-send-email-kirill@shutemov.name> <1224225264-8483-1-git-send-email-kirill@shutemov.name> <1224225264-8483-2-git-send-email-kirill@shutemov.name> <490C2253.3020005@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iFRdW5/EC4oqxDHL" Content-Disposition: inline In-Reply-To: <490C2253.3020005@web.de> Subject: [Qemu-devel] Re: [PATCH] linux-user, x86: use target_mmap() to allocate idt, gdt and ldt tables Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org --iFRdW5/EC4oqxDHL Content-Type: multipart/mixed; boundary="KFztAG8eRSV9hGtP" Content-Disposition: inline --KFztAG8eRSV9hGtP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 01, 2008 at 10:33:07AM +0100, Jan Kiszka wrote: > Kirill A. Shutemov wrote: > > env->*dt.base should fits target address space, so we should use > > target_mmap to allocate it. >=20 > I just noticed that this bug is still unfixed upstream, was about to > repost my corresponding patch [1], but then found this even nicer > approach. Could someone please finally merge a fix? >=20 > Kirill, do you also have a patch for the problem [2] addresses in your > queue? No, I don't. But we also can use target_mmap(with my mmap_find_vma()) for it, I guess. Can you provide any testcase to reproduce the bug? >=20 > Last time I posted my series, Anthony remarked that the role of the > linux-user maintainer is vacant. My impression is that this is still the > case while at the same time Kirill is doing quite a good job now getting > this corner of qemu in shape again...... :-> I'm interested in commit access. I've already asked about it, but I haven't got any responce. I've attached ssh-key just in case. ;) >=20 > Jan >=20 > [1] http://permalink.gmane.org/gmane.comp.emulators.qemu/28386 > [2] http://permalink.gmane.org/gmane.comp.emulators.qemu/28385 > > @@ -283,9 +284,8 @@ static void write_dt(void *ptr, unsigned long addr,= unsigned long limit, > > p[1] =3D tswap32(e2); > > } > > =20 > > +uint64_t *idt_table; >=20 > This should become static... Updated patch has been sent. --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --KFztAG8eRSV9hGtP Content-Type: text/plain; charset=us-ascii; name="id_dsa.pub" Content-Disposition: attachment; filename="id_dsa.pub" Content-Transfer-Encoding: quoted-printable ssh-dss AAAAB3NzaC1kc3MAAAEBAOlkJ0ucchMEy6shLwYplKpRx8RO1WtJbtMsspWDQlMu6X9= DnRZZbiBCo5FwSWuHQbGF+cjUEQM9vYezdyz+slmZQ0Dv8eS/8eqQPpUi9QVpiVOWK8JTh/kqUm= XjoFf+oiRAvaXhzGz0nWOtqxQimxMVYD3rxHcM44/TztMOI0J1vZVxep86Uw0jgMfEITanJk65x= AEo5dQkF6UbQ5eOw7+Y8ZFurjTQ6R2ZNNPB0tc7HyinDdyRzx8gIA7VYC1yLi3UWcX4in2dczFf= LDYRlfLW0Jpz/1i22IGC5Iww27ab+CYSxPNFh36Gc1vrC67F9IE2DC7JFhCNl34Bdt3wEE0AAAA= VANjSWDGw+eHsj2U1BLVFNWyMisorAAABAQC2c9ey+myRb4wqcPrHwl0CgmL7Ct2fpqYFSHtphQ= iL0q6PS8t0/wKKnmquOTrnGkiYMbqBY9OyEg9/c9dAHfZsw+Y3/yDhATIJV18nuyX6OV9lGy1O2= E7yUrR9AiO4MinG+aERx2QehTwlwPTy2ANO1B54hCVGfv9oThbB2Sb2tqegjvoWRlfzLyXg0xyC= PkB9USkRajxbIMvkZ9JYPaQsKGtJIfDqVHL9moJzGdo83UU5vkAJCZDYumOe+PDIGlrpY1z3bl1= MhWfggT+eVKxQsrU/rFh7sI0LQ7+ENLSQq6MWxYdNFVUFDrqWJxOc/1FlkgOMnMFFOkRkOFCqSu= KyAAABAH21LqMMxYNaJ23nYumWeJHVPbXLMZBCRHX0c9krdnqN67xNI2WPfJ3kD+qs7quiCIlWt= 5FGopeH9LjDluVBBz/U7aK072BA3fm5kVlgmlZPgktskMysm8D6UhZvDOgfUgP8qofOPXF9kP5m= I7mI8RIxHIiOmyCl+2NbAw/p9owyTzPvwd/kMh6O9ImBtLk5TxTFJIUskCmp1rRx/ZqYqXgp8+D= GhCGVqIUaiI2KE32ZMlCY9Mp0Eif18UggldRbgITX2xgPuewk496i2MbObT8TF/yHOtXAsnCSdj= mRLR556TmiW5g0qQisxs+xyxWeUhN7Cwyz0pYLrNuFngJggUA=3D kir@localhost.localdom= ain --KFztAG8eRSV9hGtP-- --iFRdW5/EC4oqxDHL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkkMLwsACgkQbWYnhzC5v6oa1ACdFVbMLB2elOkuUN17apbl/s4F SmgAnRII+vNya/ReI+I0I+7eI3jvbMtT =Ioz1 -----END PGP SIGNATURE----- --iFRdW5/EC4oqxDHL--