From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwEOx-0005am-QM for qemu-devel@nongnu.org; Sat, 01 Nov 2008 07:12:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwEOv-0005aF-FA for qemu-devel@nongnu.org; Sat, 01 Nov 2008 07:12:18 -0400 Received: from [199.232.76.173] (port=38882 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwEOv-0005aC-2m for qemu-devel@nongnu.org; Sat, 01 Nov 2008 07:12:17 -0400 Received: from nf-out-0910.google.com ([64.233.182.188]:16389) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KwEOu-00040o-Hs for qemu-devel@nongnu.org; Sat, 01 Nov 2008 07:12:16 -0400 Received: by nf-out-0910.google.com with SMTP id b2so1163045nfb.12 for ; Sat, 01 Nov 2008 04:12:15 -0700 (PDT) Date: Sat, 1 Nov 2008 13:12:13 +0200 From: "Kirill A. Shutemov" Message-ID: <20081101111213.GA3736@localhost.localdomain> References: <1223892640-15545-13-git-send-email-kirill@shutemov.name> <1224225264-8483-1-git-send-email-kirill@shutemov.name> <1224225264-8483-2-git-send-email-kirill@shutemov.name> <490C2253.3020005@web.de> <20081101102723.GB26770@localhost.localdomain> <490C3548.1040903@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline In-Reply-To: <490C3548.1040903@web.de> Subject: [Qemu-devel] Re: [PATCH] linux-user, x86: use target_mmap() to allocate idt, gdt and ldt tables Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 01, 2008 at 11:54:00AM +0100, Jan Kiszka wrote: > Kirill A. Shutemov wrote: > > On Sat, Nov 01, 2008 at 10:33:07AM +0100, Jan Kiszka wrote: > >> Kirill A. Shutemov wrote: > >>> env->*dt.base should fits target address space, so we should use > >>> target_mmap to allocate it. > >> I just noticed that this bug is still unfixed upstream, was about to > >> repost my corresponding patch [1], but then found this even nicer > >> approach. Could someone please finally merge a fix? > >> > >> Kirill, do you also have a patch for the problem [2] addresses in your > >> queue? > >=20 > > No, I don't. But we also can use target_mmap(with my mmap_find_vma()) f= or > > it, I guess. Can you provide any testcase to reproduce the bug? >=20 > I don't have a testcase for this. I just came across it at the time this > h2g usage caused a compiler warning. Laster on, this warning was papered > over, but the bug remained though I reminded people a few times. >=20 > We don't need special allocation here (that's what I originally thought > as well), we just need a robust way of detecting the guest-host address > conflict: You are right. >=20 > http://article.gmane.org/gmane.comp.emulators.qemu/28381 >=20 > Maybe you can go through my old series and pick up the bits that still > make sense. The user emulation is not on my daily radar, so these things > could be forgotten again if I have to track them. :-] Your patches 1,4,5 look good for me. --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --AqsLC8rIMeq19msA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkkMOY0ACgkQbWYnhzC5v6pBhACfd1KavYNRyr0Lgis6+hr6WMuv skUAn2nx+l3uQS1w/Ax1LClWi+SH4pEA =QXaH -----END PGP SIGNATURE----- --AqsLC8rIMeq19msA--