From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KwG5X-0007cI-3Y
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 09:00:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KwG5V-0007bo-GT
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 09:00:22 -0400
Received: from [199.232.76.173] (port=43556 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KwG5V-0007bh-1h
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 09:00:21 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:44733)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KwG5U-0001DT-7o
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 09:00:20 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for
	debugging
Date: Sat, 1 Nov 2008 13:59:51 +0100
References: <f43fc5580810291231i32552e3dw71db583d5b2bad6f@mail.gmail.com>
	<4909808C.5040602@bellard.org>
	<f43fc5580811010500n48bcef6ay9ddfdaa89884d3f0@mail.gmail.com>
In-Reply-To: <f43fc5580811010500n48bcef6ay9ddfdaa89884d3f0@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200811011259.52947.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> This version introduces TCGv_i32 and TCGv_i64. TCGv_ptr and TCGv (TL
> sized) are based on them.

This is looking good to me.

> For Sparc, the patch is very invasive (I just commented out the
> helpers to avoid that part)  but I think i386 would need much smaller
> changes.
>
> With the patch, I found some bugs in Sparc translation. I'm not sure
> what to do with helpers, there should be a way to declare the size of
> the arguments somehow and then the calling should be easier than:
> tcg_gen_helper_1_4_i64_tl_i32_i32_i32(helper_ld_asi, dst, addr, r_asi,
> r_size, r_sign);

I think we can build some infrastructure to make helpers easier to handle.  
It should be relatively mechanical changes to the existing helper[s].h.  ARM 
and m68k already do this, though need a bit more work to get static 
typechecking.  All the information it there's it's just not quite in the 
right form.  I'll see if I can dig out the CPP magic required for this.

Paul