From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KwJh0-0008Vt-GB
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:51:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KwJgw-0008Vh-3s
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:51:17 -0400
Received: from [199.232.76.173] (port=59575 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KwJgv-0008Ve-VR
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:51:13 -0400
Received: from mail2.shareable.org ([80.68.89.115]:59510)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1KwJgv-00022t-Hb
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:51:13 -0400
Date: Sat, 1 Nov 2008 16:51:10 +0000
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH,
	v2] Rewrite mmap_find_vma() to work fine on 64-bit hosts with 32-bit
	targets
Message-ID: <20081101165110.GA6991@shareable.org>
References: <1223892640-15545-11-git-send-email-kirill@shutemov.name>
	<1225129768-11603-1-git-send-email-kirill@shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1225129768-11603-1-git-send-email-kirill@shutemov.name>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>

Kirill A. Shutemov wrote:
> +        /* Unmap and try again with new page */
> +        munmap(ptr, size);
>          addr += qemu_host_page_size;

Won't this be rather slow if it has to skip a large mapped area, one
page at a time?

-- Jamie