From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KwJlP-0000vT-1Q
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:55:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KwJlM-0000v8-KG
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:55:49 -0400
Received: from [199.232.76.173] (port=35628 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KwJlM-0000v5-Ey
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:55:48 -0400
Received: from ey-out-1920.google.com ([74.125.78.144]:61047)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirill@shutemov.name>) id 1KwJlL-0002XN-VD
	for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:55:48 -0400
Received: by ey-out-1920.google.com with SMTP id 4so623758eyk.4
	for <qemu-devel@nongnu.org>; Sat, 01 Nov 2008 09:55:46 -0700 (PDT)
Date: Sat, 1 Nov 2008 18:55:44 +0200
From: "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [Qemu-devel] [PATCH, v2] Rewrite mmap_find_vma() to work fine
	on 64-bit hosts with 32-bit targets
Message-ID: <20081101165543.GA5076@localhost.localdomain>
References: <1223892640-15545-11-git-send-email-kirill@shutemov.name>
	<1225129768-11603-1-git-send-email-kirill@shutemov.name>
	<20081101165110.GA6991@shareable.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62"
Content-Disposition: inline
In-Reply-To: <20081101165110.GA6991@shareable.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel@nongnu.org


--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 01, 2008 at 04:51:10PM +0000, Jamie Lokier wrote:
> Kirill A. Shutemov wrote:
> > +        /* Unmap and try again with new page */
> > +        munmap(ptr, size);
> >          addr +=3D qemu_host_page_size;
>=20
> Won't this be rather slow if it has to skip a large mapped area, one
> page at a time?

If we skip more than one page we increase memory fragmentation.

--=20
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkkMig8ACgkQbWYnhzC5v6pD4gCfdDlTGXiiwHvd+hkELIjvhSr/
3AkAn1IhjveMpPCQa4yqJKqxM51HasI3
=URZ4
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--