From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwJmC-0001Gz-Gr for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:56:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwJmA-0001G1-JJ for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:56:39 -0400 Received: from [199.232.76.173] (port=35636 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwJmA-0001Fx-DA for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:56:38 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:47363) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KwJm9-0002bT-Og for qemu-devel@nongnu.org; Sat, 01 Nov 2008 12:56:38 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for debugging Date: Sat, 1 Nov 2008 17:56:26 +0100 References: <200811011259.52947.paul@codesourcery.com> In-Reply-To: <200811011259.52947.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811011656.29847.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl > > With the patch, I found some bugs in Sparc translation. I'm not sure > > what to do with helpers, there should be a way to declare the size of > > the arguments somehow and then the calling should be easier than: > > tcg_gen_helper_1_4_i64_tl_i32_i32_i32(helper_ld_asi, dst, addr, r_asi, > > r_size, r_sign); > > I think we can build some infrastructure to make helpers easier to handle. > It should be relatively mechanical changes to the existing helper[s].h. > ARM and m68k already do this, though need a bit more work to get static > typechecking. All the information it there's it's just not quite in the > right form. I'll see if I can dig out the CPP magic required for this. I've got something that works. Any chance you could resend you patch with a signed-off-by line so I can do the integration? Paul