From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [5601] Halt the CPU using a qemu_irq
Date: Sun, 2 Nov 2008 13:12:53 +0100 [thread overview]
Message-ID: <200811021213.05223.paul@codesourcery.com> (raw)
In-Reply-To: <E1KwaXy-0007Ng-Lx@cvs.savannah.gnu.org>
> +static void cpu_halt_signal(void *opaque, int irq, int level)
> +{
> + if (level && cpu_single_env)
> + cpu_interrupt(cpu_single_env, CPU_INTERRUPT_HALT);
> +}
>...
> + cpu_halt = qemu_allocate_irqs(cpu_halt_signal, NULL, 1);
Will this DTRT for SMP, or should we be including cpu_env as an argument to
cpu_halt_signal? Relying on cpu_single_env being set in an IRQ handler seems
kinda sketchy.
Paul
next prev parent reply other threads:[~2008-11-02 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 10:51 [Qemu-devel] [5601] Halt the CPU using a qemu_irq Blue Swirl
2008-11-02 12:12 ` Paul Brook [this message]
2008-11-02 12:23 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811021213.05223.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).