From: "M. Warner Losh" <imp@bsdimp.com>
To: qemu-devel@nongnu.org, jamie@shareable.org
Cc: jan.kiszka@web.de
Subject: Re: [Qemu-devel] Re: [5578] Increase default IO timeout from 10ms to 5s
Date: Tue, 04 Nov 2008 09:22:31 -0700 (MST) [thread overview]
Message-ID: <20081104.092231.-1384053398.imp@bsdimp.com> (raw)
In-Reply-To: <20081104113204.GA32125@shareable.org>
In message: <20081104113204.GA32125@shareable.org>
Jamie Lokier <jamie@shareable.org> writes:
: andrzej zaborowski wrote:
: > > My man page even warns that the Linux
: > > kernel is not implementing it yet, though I don't think this still
: > > applies to recent 2.6.2x kernels.
: >
: > According to the man page it moved to kernel at 2.6.16 but the glibc
: > wrapper should be ok too.
:
: If there's a glibc wrapper, it cannot be reliable...
:
: *Looks at glibc source*
:
: That's right. The glibc pselect() wrapper has the same race condition
: which prompted this QEMU bug. If the signal arrives after unmasking
: and before select() in the wrapper, then blocks.
:
: In other words, don't use pselect() if you might run on a kernel older
: than 2.6.16, or on a host architecture which adds pselect() in a later
: kernel version. Also, I wouldn't be surprised if older versions of
: some BSDs have similar dodgy wrappers.
Which ones have a good kernel implementation of it? FreeBSD's is
currently approximately:
if (!mask)
_sigprocmask(mask, &oldmask);
/* here */
select();
if (!mask)
_sigprocmask(oldmask, NULL);
I'm assuming that the problem is due to a signal arriving at /* here */.
Warner
next prev parent reply other threads:[~2008-11-04 16:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 18:40 [Qemu-devel] [5578] Increase default IO timeout from 10ms to 5s Anthony Liguori
2008-10-31 18:52 ` Anthony Liguori
2008-11-02 19:08 ` [Qemu-devel] " Jan Kiszka
2008-11-03 20:04 ` Anthony Liguori
2008-11-03 20:36 ` Jan Kiszka
2008-11-03 21:50 ` Jan Kiszka
2008-11-03 22:00 ` Anthony Liguori
2008-11-03 22:03 ` Jan Kiszka
2008-11-04 8:07 ` andrzej zaborowski
2008-11-04 8:22 ` Jan Kiszka
2008-11-04 8:33 ` andrzej zaborowski
2008-11-04 11:32 ` Jamie Lokier
2008-11-04 16:22 ` M. Warner Losh [this message]
2008-11-04 17:10 ` Jan Kiszka
2008-11-04 17:55 ` M. Warner Losh
2008-11-04 19:08 ` Jan Kiszka
2008-11-05 15:00 ` Jamie Lokier
2008-11-05 16:10 ` M. Warner Losh
2008-11-05 18:21 ` Jan Kiszka
2008-11-05 18:41 ` Daniel P. Berrange
2008-11-05 20:16 ` andrzej zaborowski
2008-11-05 20:28 ` Daniel P. Berrange
2008-11-05 23:38 ` Jamie Lokier
2008-11-06 0:53 ` Jamie Lokier
2008-11-06 5:19 ` M. Warner Losh
2008-11-04 8:29 ` Avi Kivity
2008-10-31 19:41 ` [Qemu-devel] " Jamie Lokier
2008-10-31 20:13 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104.092231.-1384053398.imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=jamie@shareable.org \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).