qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select
Date: Wed, 5 Nov 2008 12:36:50 +0000	[thread overview]
Message-ID: <20081105123650.GE13630@shareable.org> (raw)
In-Reply-To: <49108333.6080807@web.de>

Jan Kiszka wrote:
> +    if (pipe(fds) || fcntl(fds[0], F_SETFL, O_NONBLOCK)
> +        || fcntl(fds[1], F_SETFL, O_NONBLOCK)) {

Is this a portable way to set O_NONBLOCK on all host platforms?
I'm under the impression you need to ues F_GETFL first, in case
other flags are important to the functioning of the file descriptor.

-- Jamie

  parent reply	other threads:[~2008-11-05 12:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  7:52 [Qemu-devel] [PATCH] Fix alarm_timer race with select Jan Kiszka
2008-11-04 14:07 ` Anthony Liguori
2008-11-04 14:27   ` Anthony Liguori
2008-11-04 17:15     ` [Qemu-devel] " Jan Kiszka
2008-11-04 17:38       ` Anthony Liguori
2008-11-04 19:16       ` Anthony Liguori
2008-11-04 19:37         ` Jan Kiszka
2008-11-05 12:36       ` Jamie Lokier [this message]
2008-11-05 13:01         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081105123650.GE13630@shareable.org \
    --to=jamie@shareable.org \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).