From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KzS4d-0007xy-8O
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 03:24:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KzS4b-0007x6-JQ
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 03:24:38 -0500
Received: from [199.232.76.173] (port=55864 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KzS4b-0007wy-Du
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 03:24:37 -0500
Received: from mx20.gnu.org ([199.232.41.8]:46408)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gleb@redhat.com>) id 1KzS4a-00022q-PO
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 03:24:36 -0500
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1KzS4Z-00081B-Df
	for qemu-devel@nongnu.org; Mon, 10 Nov 2008 03:24:35 -0500
Date: Mon, 10 Nov 2008 10:24:32 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20081110082432.GB32281@redhat.com>
References: <20081103092620.8058.91416.stgit@dhcp-1-237.local>
	<20081103092630.8058.77287.stgit@dhcp-1-237.local>
	<FB397EAE9EAE48E998C22DEEBF3FD305@FSCPC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <FB397EAE9EAE48E998C22DEEBF3FD305@FSCPC>
Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v2 2/6] Add S3 state to
	DSDT. Handleresume event in the BIOS.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org

On Fri, Nov 07, 2008 at 12:03:02AM +0100, Sebastian Herbszt wrote:
>> +    Name (\_S3, Package (0x04)
>> +    {
>> +        0x01,  /* PM1a_CNT.SLP_TYP */
>> +        0x01,  /* PM1b_CNT.SLP_TYP */
>> +        Zero,  /* reserved */
>> +        Zero   /* reserved */
>> +    })
>> +    Name (\_S4, Package (0x04)
>> +    {
>> +        Zero,  /* PM1a_CNT.SLP_TYP */
>> +        Zero,  /* PM1b_CNT.SLP_TYP */
>> +        Zero,  /* reserved */
>> +        Zero   /* reserved */
>> +    })
>
> Do we need \_S4 for S3 support?
>
Strictly saying no we don't, but S4 is supported by the chipset
we emulate (it is the same as power-off), so why don't advertise
it explicitly?

Other comments are addressed in v3 of the patch series.

--
			Gleb.