From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L0DB4-0004as-JZ
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 05:42:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L0DB2-0004ag-Ok
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 05:42:26 -0500
Received: from [199.232.76.173] (port=46092 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L0DB2-0004ad-IT
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 05:42:24 -0500
Received: from verein.lst.de ([213.95.11.210]:50383)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1L0DB2-0004GK-1B
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 05:42:24 -0500
Received: from verein.lst.de (localhost [127.0.0.1])
	by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id
	mACAgGIF011872
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <qemu-devel@nongnu.org>; Wed, 12 Nov 2008 11:42:16 +0100
Received: (from hch@localhost)
	by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id mACAgGY0011870
	for qemu-devel@nongnu.org; Wed, 12 Nov 2008 11:42:16 +0100
Date: Wed, 12 Nov 2008 11:42:15 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [5627] Add KVM support to QEMU
Message-ID: <20081112104215.GA11733@lst.de>
References: <E1Kxkrx-0006Lk-OG@cvs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1Kxkrx-0006Lk-OG@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Nov 05, 2008 at 04:04:33PM +0000, Anthony Liguori wrote:
> +# kvm probe
> +if test "$kvm" = "yes" ; then
> +    cat > $TMPC <<EOF
> +#include <linux/kvm.h>
> +#if !defined(KVM_API_VERSION) || \
> +    KVM_API_VERSION < 12 || \
> +    KVM_API_VERSION > 12 || \
> +    !defined(KVM_CAP_USER_MEMORY) || \
> +    !defined(KVM_CAP_SET_TSS_ADDR)
> +#error Invalid KVM version
> +#endif

The installed linux/kvm.h has no relatation at all to the currently
running kernel.   Please ship a current max API version kvm.h with qemu
and always build against that one, and handle lower API versions at
runtime.  Please don't turn mainline qemu kvm support into the same
bloody mess as the kvm userspace repository.