From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [5685] Disable debug code for production.
Date: Wed, 12 Nov 2008 12:50:56 +0000 [thread overview]
Message-ID: <200811121250.56809.paul@codesourcery.com> (raw)
In-Reply-To: <E1KztK7-0008Ke-2B@cvs.savannah.gnu.org>
> /* allow to see translation results - the slowdown should be negligible,
> so we leave it */
> -#define DEBUG_DISAS
> +//#define DEBUG_DISAS
Why? As the comment says this has almost no runtime overhead, so there's no
real downside to leaving it enabled. After your change the code is
inconsistent with the comment.
If we really want to disble this for production builds then IMHO it can be
done by whoever spins the release.
Paul
next prev parent reply other threads:[~2008-11-12 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 13:30 [Qemu-devel] [5685] Disable debug code for production Aurelien Jarno
2008-11-12 12:50 ` Paul Brook [this message]
2008-11-12 15:22 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811121250.56809.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).