[Qemu-devel] [5685] Disable debug code for production.

[Qemu-devel] [5685] Disable debug code for production.

[Aurelien Jarno]

Revision: 5685
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5685
Author:   aurel32
Date:     2008-11-11 13:30:24 +0000 (Tue, 11 Nov 2008)

Log Message:
-----------
Disable debug code for production.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/exec-all.h

Modified: trunk/exec-all.h
===================================================================
--- trunk/exec-all.h	2008-11-11 11:50:51 UTC (rev 5684)
+++ trunk/exec-all.h	2008-11-11 13:30:24 UTC (rev 5685)
@@ -21,7 +21,7 @@
 #ifndef _EXEC_ALL_H_
 #define _EXEC_ALL_H_
 /* allow to see translation results - the slowdown should be negligible, so we leave it */
-#define DEBUG_DISAS
+//#define DEBUG_DISAS
 
 /* is_jmp field values */
 #define DISAS_NEXT    0 /* next instruction can be analyzed */

Re: [Qemu-devel] [5685] Disable debug code for production.

[Paul Brook]

>  /* allow to see translation results - the slowdown should be negligible,
> so we leave it */
> -#define DEBUG_DISAS 
> +//#define DEBUG_DISAS

Why? As the comment says this has almost no runtime overhead, so there's no 
real downside to leaving it enabled. After your change the code is 
inconsistent with the comment.
If we really want to disble this for production builds then IMHO it can be 
done by whoever spins the release.

Paul

Re: [Qemu-devel] [5685] Disable debug code for production.

[Aurelien Jarno]

Paul Brook a écrit :
>>  /* allow to see translation results - the slowdown should be negligible,
>> so we leave it */
>> -#define DEBUG_DISAS 
>> +//#define DEBUG_DISAS
> 
> Why? As the comment says this has almost no runtime overhead, so there's no 
> real downside to leaving it enabled. After your change the code is 
> inconsistent with the comment.
> If we really want to disble this for production builds then IMHO it can be 
> done by whoever spins the release.
> 

This has been committed by mistake, and reverted later.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net