From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0FBj-0003hG-Qu for qemu-devel@nongnu.org; Wed, 12 Nov 2008 07:51:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0FBi-0003gR-8d for qemu-devel@nongnu.org; Wed, 12 Nov 2008 07:51:15 -0500 Received: from [199.232.76.173] (port=58992 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0FBi-0003gM-4T for qemu-devel@nongnu.org; Wed, 12 Nov 2008 07:51:14 -0500 Received: from mail.codesourcery.com ([65.74.133.4]:42302) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0FBh-0006MZ-Ex for qemu-devel@nongnu.org; Wed, 12 Nov 2008 07:51:13 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [5685] Disable debug code for production. Date: Wed, 12 Nov 2008 12:50:56 +0000 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811121250.56809.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno > /* allow to see translation results - the slowdown should be negligible, > so we leave it */ > -#define DEBUG_DISAS > +//#define DEBUG_DISAS Why? As the comment says this has almost no runtime overhead, so there's no real downside to leaving it enabled. After your change the code is inconsistent with the comment. If we really want to disble this for production builds then IMHO it can be done by whoever spins the release. Paul