From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L0hAu-0001Zl-Qn
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 13:44:16 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L0hAt-0001ZZ-Fi
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 13:44:16 -0500
Received: from [199.232.76.173] (port=42017 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L0hAt-0001ZW-9m
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 13:44:15 -0500
Received: from mail.codesourcery.com ([65.74.133.4]:37362)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1L0hAs-0006Fo-Gi
	for qemu-devel@nongnu.org; Thu, 13 Nov 2008 13:44:15 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] add file: migration support (r2)
Date: Thu, 13 Nov 2008 18:44:11 +0000
References: <gfhq8c$pjm$1@ger.gmane.org>
In-Reply-To: <gfhq8c$pjm$1@ger.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200811131844.11491.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Charles Duffy <Charles_Duffy@messageone.com>

On Thursday 13 November 2008, Charles Duffy wrote:
> This patch adds support for migration to and from file: targets, moves
> common helpers between exec: and file: use cases from migration-exec.c
> to migration.c, and adds a qemu_fdopen() helper parallel to qemu_fopen().
>
> Compared to the previous version submitted, it removes some cruft which
> was accidentally included, and documents the limitations of O_NONBLOCK
> on Linux with local filesystem access.

I don't see any documentation.

The documentation should make it clear that this is not intended as a 
substitute for savvm/loadvm. A "live" migration doesn't make sense if you're 
writing to an actual file (rather than a FIFO) as you'll end up with 
unecessarily large files.

Paul