From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0ptv-0000fG-2M for qemu-devel@nongnu.org; Thu, 13 Nov 2008 23:03:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0ptt-0000f4-Ui for qemu-devel@nongnu.org; Thu, 13 Nov 2008 23:03:18 -0500 Received: from [199.232.76.173] (port=49492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0ptt-0000f1-MW for qemu-devel@nongnu.org; Thu, 13 Nov 2008 23:03:17 -0500 Received: from mail2.shareable.org ([80.68.89.115]:56386) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0ptt-0002C3-8F for qemu-devel@nongnu.org; Thu, 13 Nov 2008 23:03:17 -0500 Date: Fri, 14 Nov 2008 04:03:11 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH][RFC] Split non-TCG bits out of exec.c Message-ID: <20081114040311.GN2055@shareable.org> References: <1226527840-14183-1-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1226527840-14183-1-git-send-email-aliguori@us.ibm.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Carsten Otte , Anthony Liguori , Hollis Blanchard , kvm-devel , Paul Brook Anthony Liguori wrote: > Unlike kqemu, KVM does not use TCG at all when accelerating QEMU. Having TCG > present is not a problem when using KVM on x86. x86 already has TCG host and > target support and it's quite convenient to be able to disable/enable KVM and > compare it to TCG when debugging. I agree with removing/isolating the dependency on TCG, and there are good reasons for it. But does the fact KVM doesn't use TCG prevent KVM from running some x86 modes correctly? E.g. I gather 16-bit code is run by KVM using VM86 mode, which is not exactly correct. It would be nice to have KVM acceleration but also complete and correct emulation, by switching to TCG for those modes. Also, an earlier thread pointed out that loops doing a lot of MMIO are _slower_ with KVM than without - this manifested as very slow VGA output for some guests. Having KVM pass control to TCG for short runs of guest instructions which do MMIO, or other instructions which need to be emulated, would accelerate KVM in this respect. -- Jamie