From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L1PNZ-0005Sq-EK
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 12:56:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L1PNY-0005Sd-RH
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 12:56:17 -0500
Received: from [199.232.76.173] (port=43507 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L1PNY-0005Sa-L8
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 12:56:16 -0500
Received: from mx2.redhat.com ([66.187.237.31]:50363)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1L1PNY-0001nk-DZ
	for qemu-devel@nongnu.org; Sat, 15 Nov 2008 12:56:16 -0500
Date: Sat, 15 Nov 2008 19:56:20 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20081115175620.GC6059@redhat.com>
References: <20081110091134.11822.34230.stgit@dhcp-1-237.local>
	<20081110091144.11822.2723.stgit@dhcp-1-237.local>
	<67824189A71746ACA0DBE3A86D3A647B@FSCPC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67824189A71746ACA0DBE3A86D3A647B@FSCPC>
Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v3 2/6] Add S3 state to
	DSDT. Handleresume event in the BIOS.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org

On Sat, Nov 15, 2008 at 06:43:44PM +0100, Sebastian Herbszt wrote:
> Any reason not to immediately return if the wakeup vector is NULL?
>
> @@ -2092,8 +2100,8 @@ void rombios32_init(uint32_t *s3_resume_
>             /* redirect bios read access to RAM */
>             pci_for_each_device(find_440fx);
>             bios_lock_shadow_ram(); /* bios is already copied */
> -            return;
>         }
> +        return;
>     }
>
>     pci_bios_init();
The idea was that if wakeup vector is NULL we proceed with regular
boot process. After changing S3 resume to not do normal POST, but 
jump to s3_post instead that's no longer works. Lets return here earlier
as you suggest and s3_resume can jump to normal POST if resume vector is
NULL.

--
			Gleb.