From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L1fax-0001Dw-Ps for qemu-devel@nongnu.org; Sun, 16 Nov 2008 06:15:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L1faw-0001DZ-VN for qemu-devel@nongnu.org; Sun, 16 Nov 2008 06:15:11 -0500 Received: from [199.232.76.173] (port=56924 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L1faw-0001DW-Jt for qemu-devel@nongnu.org; Sun, 16 Nov 2008 06:15:10 -0500 Received: from mx2.redhat.com ([66.187.237.31]:48561) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L1faw-0007EU-6J for qemu-devel@nongnu.org; Sun, 16 Nov 2008 06:15:10 -0500 Date: Sun, 16 Nov 2008 13:15:13 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH v4 1/5] Add S3 state to DSDT. Handle resume event in the BIOS. Message-ID: <20081116111513.GN20617@redhat.com> References: <20081116093345.23209.79952.stgit@dhcp-1-237.local> <20081116093350.23209.81418.stgit@dhcp-1-237.local> <20081116110141.GM20617@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org On Sun, Nov 16, 2008 at 01:11:21PM +0200, Blue Swirl wrote: > On 11/16/08, Gleb Natapov wrote: > > On Sun, Nov 16, 2008 at 12:50:55PM +0200, Blue Swirl wrote: > > > On 11/16/08, Gleb Natapov wrote: > > > > +void s3_resume_panic() > > > > > > How about rather: > > > void s3_resume_panic(void) > > > > > > > +int > > > > +s3_resume() > > > > > > s3_resume(void)? > > > > > > Have you tried it? :) > > > > Hint: bcc doesn't support ANSI-C. > > Oh, no. > > Doesn't Linux use gcc even for 16 bit code these days? Why can't bochs > do the same? There is a project to do just that + rewrite entire BIOS to be C (mostly). http://www.coreboot.org/SeaBIOS. Sometime Qemu should move to it. -- Gleb.