From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L1lwA-0005Gl-Bn
	for qemu-devel@nongnu.org; Sun, 16 Nov 2008 13:01:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L1lw8-0005GO-Gv
	for qemu-devel@nongnu.org; Sun, 16 Nov 2008 13:01:29 -0500
Received: from [199.232.76.173] (port=43749 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L1lw8-0005G8-8z
	for qemu-devel@nongnu.org; Sun, 16 Nov 2008 13:01:28 -0500
Received: from mx2.redhat.com ([66.187.237.31]:52569)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1L1lw8-000676-4p
	for qemu-devel@nongnu.org; Sun, 16 Nov 2008 13:01:28 -0500
Date: Sun, 16 Nov 2008 20:01:29 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Bochs-developers] [Qemu-devel] [PATCH v4 1/5] Add S3 state
	toDSDT. Handle resume event in the BIOS.
Message-ID: <20081116180129.GE6059@redhat.com>
References: <20081116110141.GM20617@redhat.com>
	<55BF96155E3B42A2A577975171920809@FSCPC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55BF96155E3B42A2A577975171920809@FSCPC>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org

On Sun, Nov 16, 2008 at 06:54:38PM +0100, Sebastian Herbszt wrote:
> Gleb Natapov wrote:
>> On Sun, Nov 16, 2008 at 12:50:55PM +0200, Blue Swirl wrote:
>>> On 11/16/08, Gleb Natapov <gleb@redhat.com> wrote:
>>> >  +void s3_resume_panic()
>>>
>>> How about rather:
>>> void s3_resume_panic(void)
>>>
>>> >  +int
>>> >  +s3_resume()
>>>
>>> s3_resume(void)?
>>
>> Have you tried it? :)
>>
>> Hint: bcc doesn't support ANSI-C.
>
> It accepts some ansi-c with "-ansi". Man page says
> "-ansi  Pass  the  C  source  through unprotoize after preprocessing and
> before code generation. This will allow some ansi C to be compiled but
> it is definitly NOT a true ansi-C compiler."
>
But BOCHS doesn't use this flag. Do you what to add it and fix all
function prototypes? Seems like to much work for a little gain.


--
			Gleb.