From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2CpZ-0001xC-CS
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:44:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2CpX-0001wn-Rc
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:44:28 -0500
Received: from [199.232.76.173] (port=41757 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2CpX-0001wk-Nm
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:44:27 -0500
Received: from 42.mail-out.ovh.net ([213.251.189.42]:33368)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <plagnioj@jcrosoft.com>) id 1L2CpX-00086a-Hw
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:44:27 -0500
Date: Mon, 17 Nov 2008 23:39:29 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support
Message-ID: <20081117223929.GB20874@game.jcrosoft.org>
References: <09739678475eecbf3d9de512bf1dd13d07bd6642.1226955410.git.hollisb@us.ibm.com>
	<9d5d305c23980946944437d1116f3f83430b40e2.1226955410.git.hollisb@us.ibm.com>
	<20081117220709.GA20874@game.jcrosoft.org>
	<1226961319.3702.38.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1226961319.3702.38.camel@localhost.localdomain>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 16:35 Mon 17 Nov     , Hollis Blanchard wrote:
> On Mon, 2008-11-17 at 23:07 +0100, Jean-Christophe PLAGNIOL-VILLARD
> wrote:
> > On 15:18 Mon 17 Nov     , Hollis Blanchard wrote:
> > >  /* Load a U-Boot image.  */
> > >  int load_uboot(const char *filename, target_ulong *ep, int *is_linux)
> > >  {
> > > -
> > >      int fd;
> > >      int size;
> > >      uboot_image_header_t h;
> > > @@ -374,9 +459,9 @@ int load_uboot(const char *filename, target_ulong *ep, int *is_linux)
> > >          goto fail;
> > >      }
> > >  
> > > -    /* TODO: Implement compressed images.  */
> > > -    if (hdr->ih_comp != IH_COMP_NONE) {
> > > -        fprintf(stderr, "Unable to load compressed u-boot images\n");
> > > +    /* TODO bzip2 support */
> > > +    if (hdr->ih_comp == IH_COMP_BZIP2) {
> > > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot images\n");
> > >          goto fail;
> > >      }
> > why do you remove the non compress mode?
> 
> I do not.
Sorry I miss
> 
> > BTW Please note 2 thinks
> > First this format of uImage is deprecated
> > we have switch to a fdt uImage format
> 
> I see a new "fit" format; I assume this is what you're referring to. Who
> is "we"?
U-Boot dev & Maintainer
> It looks like Linux does not yet use this format, neither for
> PowerPC (my personal interest) nor ARM.

No the PowerPC has switch to it
And some ARM board will do as AT91

> 
> > Secondly we aslo support now LZMA compression
> 
> That's good to know, but PowerPC Linux has traditionally and continues
> to use gzip uImages, so that's what this patch implements.

Some boards as qemu_mips and some other ARM board start to use it

Best Regards,
J.