From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2CvG-0004tw-0M
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:50:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2CvE-0004tk-Kn
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:50:21 -0500
Received: from [199.232.76.173] (port=34239 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2CvE-0004th-Ga
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:50:20 -0500
Received: from 42.mail-out.ovh.net ([213.251.189.42]:33937)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <plagnioj@jcrosoft.com>) id 1L2CvE-0000Bo-0j
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:50:20 -0500
Date: Mon, 17 Nov 2008 23:45:21 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support
Message-ID: <20081117224521.GC20874@game.jcrosoft.org>
References: <20081117220709.GA20874@game.jcrosoft.org>
	<10837025566-BeMail@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <10837025566-BeMail@laptop>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 23:30 Mon 17 Nov     , François Revol wrote:
> > > -    /* TODO: Implement compressed images.  */
> > > -    if (hdr->ih_comp != IH_COMP_NONE) {
> > > -        fprintf(stderr, "Unable to load compressed u-boot images\
> > > n");
> > > +    /* TODO bzip2 support */
> > > +    if (hdr->ih_comp == IH_COMP_BZIP2) {
> > > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot
> > > images\n");
> > >          goto fail;
> > >      }
> > why do you remove the non compress mode?
> 
> He didn't remove it, he changed the check to only reject BZIP2, not
> uncompressed (which is wrong though as it'd accept any other compession
> including unknown).

I've missed it but as we also support LZMA now you must add the check too
> 
> > BTW Please note 2 thinks
> > First this format of uImage is deprecated
> > we have switch to a fdt uImage format
> 
> fdt ? as in flat device tree ?
> Is that documented somewhere ?
> I'll need to add U-Boot support to Haiku soon...
in the source code doc/uImage.FIT/

I'm preparing the DHT-Walnut

I've add support and doc how to use it for the qemu_mips
and the ARM soon

Best Regards,
J.