qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sheng Yang <sheng@linux.intel.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] Make QEmu depends on libpci
Date: Fri, 21 Nov 2008 22:09:53 +0800	[thread overview]
Message-ID: <200811212209.53748.sheng@linux.intel.com> (raw)
In-Reply-To: <4926C173.3090408@codemonkey.ws>

On Friday 21 November 2008 22:10:59 Anthony Liguori wrote:
> Sheng Yang wrote:
> > libpci is handy to handle some pci device related things.
> >
> > This is the same as first patch I sent in MSI userspace patchset in kvm
> > mailing list, and this one is based on QEmu upstream.
>
> It should be an optional dependency.  If libpci isn't present, then you
> should disable PCI passthrough.  See the checks for gnutls, libvde,
> bluez, etc.

OK. And I think we don't have PCI passthrough for QEmu upstream now... I will 
update the KVM side one.

-- 
regards
Yang, Sheng

>
> Regards,
>
> Anthony LIguori
>
> > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> > ---
> >  Makefile.target |    2 +-
> >  configure       |   19 +++++++++++++++++++
> >  2 files changed, 20 insertions(+), 1 deletions(-)
> >
> > diff --git a/Makefile.target b/Makefile.target
> > index 3cdf7db..7cf5b00 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -598,7 +598,7 @@ else
> >  OBJS+=block-raw-posix.o
> >  endif
> >
> > -LIBS+=-lz
> > +LIBS+=-lz -lpci
> >  ifdef CONFIG_ALSA
> >  LIBS += -lasound
> >  endif
> > diff --git a/configure b/configure
> > index 1f3d233..1f35e3d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -764,6 +764,25 @@ else
> >  fi
> >
> >  ##########################################
> > +# libpci probe
> > +cat > $TMPC << EOF
> > +#include <pci/pci.h>
> > +#ifndef PCI_VENDOR_ID
> > +#error NO LIBPCI
> > +#endif
> > +int main(void) { return 0; }
> > +EOF
> > +if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC 2>/dev/null ; then
> > +    :
> > +else
> > +    echo
> > +    echo "Error: libpci check failed"
> > +    echo "Make sure to have the libpci libs and headers installed."
> > +    echo
> > +    exit 1
> > +fi
> > +
> > +##########################################
> >  # SDL probe
> >
> >  sdl_too_old=no

      reply	other threads:[~2008-11-21 14:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21 13:41 [Qemu-devel] [PATCH] Make QEmu depends on libpci Sheng Yang
2008-11-21 14:10 ` [Qemu-devel] " Anthony Liguori
2008-11-21 14:09   ` Sheng Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811212209.53748.sheng@linux.intel.com \
    --to=sheng@linux.intel.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).