From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4De1-0006jC-Nx
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 07:00:53 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4Ddz-0006iJ-9D
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 07:00:53 -0500
Received: from [199.232.76.173] (port=50171 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4Ddy-0006iC-VJ
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 07:00:51 -0500
Received: from verein.lst.de ([213.95.11.210]:51178)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1L4Ddy-0005tG-DZ
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 07:00:51 -0500
Received: from verein.lst.de (localhost [127.0.0.1])
	by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id
	mANC0hIF003355
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <qemu-devel@nongnu.org>; Sun, 23 Nov 2008 13:00:43 +0100
Received: (from hch@localhost)
	by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id mANC0hG7003353
	for qemu-devel@nongnu.org; Sun, 23 Nov 2008 13:00:43 +0100
Date: Sun, 23 Nov 2008 13:00:43 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [5778] Use MAP_ANON also for FreeBSD (Juergen Lock)
Message-ID: <20081123120043.GA3323@lst.de>
References: <E1L3zJl-00044H-T7@cvs.savannah.gnu.org>
	<20081123100310.GA29843@shareable.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081123100310.GA29843@shareable.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Nov 23, 2008 at 10:03:10AM +0000, Jamie Lokier wrote:
> Blue Swirl wrote:
> > -#ifdef __OpenBSD__ /* no need (?) for a dummy file on OpenBSD */
> > +/* no need (?) for a dummy file on OpenBSD/FreeBSD */
> > +#if defined(__OpenBSD__) || defined(__FreeBSD__)
> >      int map_anon = MAP_ANON;
> >  #else
> >      int map_anon = 0;
> 
> How about, simply:
> 
> #ifdef MAP_ANON
> 
> (Btw, on some OSes it has the name MAP_ANONYMOUS, so in my own
> portable code I look for both.)

I'm pretty sure there are OSes around that have MAP_ANON/MAP_ANONYMOUS
but don't support it in combination with MAP_SHARED.