From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4Vz8-0000Np-EU for qemu-devel@nongnu.org; Mon, 24 Nov 2008 02:35:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4Vz6-0000NY-R4 for qemu-devel@nongnu.org; Mon, 24 Nov 2008 02:35:54 -0500 Received: from [199.232.76.173] (port=39224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4Vz6-0000NO-IQ for qemu-devel@nongnu.org; Mon, 24 Nov 2008 02:35:52 -0500 Received: from mx20.gnu.org ([199.232.41.8]:62685) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L4Vz5-0003HK-VJ for qemu-devel@nongnu.org; Mon, 24 Nov 2008 02:35:52 -0500 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4Vz4-00015S-Ue for qemu-devel@nongnu.org; Mon, 24 Nov 2008 02:35:51 -0500 Date: Mon, 24 Nov 2008 09:35:57 +0200 From: Gleb Natapov Message-ID: <20081124073557.GO11066@redhat.com> References: <20081116093345.23209.79952.stgit@dhcp-1-237.local> <20081116093355.23209.96231.stgit@dhcp-1-237.local> <6BBD568AF57A42CE81244D009F97923C@FSCPC> <20081118074628.GC11066@redhat.com> <20081118082746.GD11066@redhat.com> <79AE59D4E6D44984ADAF3F265B234562@FSCPC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79AE59D4E6D44984ADAF3F265B234562@FSCPC> Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v4 2/5] Preserve memory contentduringSMM init. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Herbszt Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org On Sun, Nov 23, 2008 at 10:15:36PM +0100, Sebastian Herbszt wrote: > Gleb Natapov wrote: >> On Tue, Nov 18, 2008 at 09:46:28AM +0200, Gleb Natapov wrote: >>> > SMBASE is not relocated. If i don't mistake smm_init() should be run on S3 >>> > resume and we would need something like >>> > >>> > pci_for_each_device(find_piix4pm) >>> > if (piix4pm_pcidev) >>> > smm_init(); >>> > >>> > in the resume path in rombios32.c. >>> > >>> Yes, you are right. I'll add it. >>> >> What about this? (fixed version of 1/5 patch) > > Looks good. > Do you intend to implement piix4_pm_reset() for qemu so register DEVACTB > is reset on qemu_system_reset_request()? > Sure, why not. -- Gleb.