From: Christoph Egger <Christoph.Egger@amd.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [5778] Use MAP_ANON also for FreeBSD (Juergen Lock)
Date: Mon, 24 Nov 2008 11:35:06 +0200 [thread overview]
Message-ID: <200811241035.06359.Christoph.Egger@amd.com> (raw)
In-Reply-To: <E1L3zJl-00044H-T7@cvs.savannah.gnu.org>
On Saturday 22 November 2008 21:43:01 Blue Swirl wrote:
> Revision: 5778
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5778
> Author: blueswir1
> Date: 2008-11-22 20:43:01 +0000 (Sat, 22 Nov 2008)
>
> Log Message:
> -----------
> Use MAP_ANON also for FreeBSD (Juergen Lock)
This is for *BSD in general.
> @@ -87,7 +89,8 @@
> static int phys_ram_size = 0;
> void *ptr;
>
> -#ifdef __OpenBSD__ /* no need (?) for a dummy file on OpenBSD */
> +/* no need (?) for a dummy file on OpenBSD/FreeBSD */
> +#if defined(__OpenBSD__) || defined(__FreeBSD__)
This should be:
#ifdef _BSD
> int map_anon = MAP_ANON;
> #else
> int map_anon = 0;
> @@ -154,7 +157,7 @@
> }
> size = (size + 4095) & ~4095;
> ftruncate(phys_ram_fd, phys_ram_size + size);
> -#endif /* !__OpenBSD__ */
> +#endif /* !(__OpenBSD__ || __FreeBSD__) */
This should be
#endif /* !_BSD */
> ptr = mmap(NULL,
> size,
> PROT_WRITE | PROT_READ, map_anon | MAP_SHARED,
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
next prev parent reply other threads:[~2008-11-24 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 20:43 [Qemu-devel] [5778] Use MAP_ANON also for FreeBSD (Juergen Lock) Blue Swirl
2008-11-23 9:10 ` Christoph Hellwig
2008-11-24 10:44 ` Christoph Egger
2008-11-24 11:07 ` Christoph Hellwig
2008-11-24 11:54 ` Christoph Egger
2008-11-23 10:03 ` Jamie Lokier
2008-11-23 12:00 ` Christoph Hellwig
2008-11-23 12:41 ` Jamie Lokier
2008-11-24 9:35 ` Christoph Egger [this message]
2008-11-24 17:40 ` M. Warner Losh
2008-11-25 10:19 ` Christoph Egger
2008-11-28 20:02 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811241035.06359.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).