From: Gleb Natapov <gleb@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb(). Fix indentation.
Date: Mon, 24 Nov 2008 22:03:43 +0200 [thread overview]
Message-ID: <20081124200343.GB3482@redhat.com> (raw)
In-Reply-To: <492AD6C4.90001@codemonkey.ws>
On Mon, Nov 24, 2008 at 10:31:00AM -0600, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>> ---
>>
>> block-qcow2.c | 78 +++++++++++++++++++++++++++++----------------------------
>> 1 files changed, 39 insertions(+), 39 deletions(-)
>>
>> diff --git a/block-qcow2.c b/block-qcow2.c
>> index dc73769..ab19a4e 100644
>> --- a/block-qcow2.c
>> +++ b/block-qcow2.c
>> @@ -1186,7 +1186,7 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>> acb->hd_aiocb = NULL;
>> if (ret < 0) {
>> - fail:
>> +fail:
>> acb->common.cb(acb->common.opaque, ret);
>> qemu_aio_release(acb);
>> return;
>> @@ -1200,8 +1200,8 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>> } else {
>> if (s->crypt_method) {
>> encrypt_sectors(s, acb->sector_num, acb->buf, acb->buf,
>> - acb->n, 0,
>> - &s->aes_decrypt_key);
>> + acb->n, 0,
>> + &s->aes_decrypt_key);
>>
>
> Why did you change this indenting? There is no tabs and I think it's
> better the way it is than how you made it.
>
I reformatted the whole function with vi autoindent. I'll drop those two
lines.
--
Gleb.
next prev parent reply other threads:[~2008-11-24 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 14:52 [Qemu-devel] [PATCH 0/5] QCOW2 small cleanups and changing metadata update order Gleb Natapov
2008-11-23 14:52 ` [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb(). Fix indentation Gleb Natapov
2008-11-24 16:31 ` Anthony Liguori
2008-11-24 20:03 ` Gleb Natapov [this message]
2008-11-23 14:53 ` [Qemu-devel] [PATCH 2/5] Introduce new helper function qcow_shedule_bh() Gleb Natapov
2008-11-24 16:32 ` Anthony Liguori
2008-11-24 20:05 ` Gleb Natapov
2008-11-23 14:53 ` [Qemu-devel] [PATCH 3/5] Write table offset and size in one syscall Gleb Natapov
2008-11-24 16:42 ` Anthony Liguori
2008-11-24 20:11 ` Gleb Natapov
2008-11-23 14:53 ` [Qemu-devel] [PATCH 4/5] Cleanup {alloc|get}_cluster_offset() Gleb Natapov
2008-11-24 16:47 ` Anthony Liguori
2008-11-23 14:53 ` [Qemu-devel] [PATCH 5/5] Change order of metadata update to prevent loosing guest data because of unexpected exit Gleb Natapov
2008-11-24 16:49 ` Anthony Liguori
2008-11-24 20:19 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124200343.GB3482@redhat.com \
--to=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).