From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4hel-0007QE-Dr
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:03:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4heh-0007Om-UQ
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:03:37 -0500
Received: from [199.232.76.173] (port=56605 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4heh-0007Oh-Mw
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:03:35 -0500
Received: from mx2.redhat.com ([66.187.237.31]:56296)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1L4heg-0007Q2-IM
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:03:35 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAOK3QLc003563
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 15:03:26 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAOK3QTl027884
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 15:03:26 -0500
Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com
	[10.35.1.237])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAOK3P9Z001197
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 15:03:25 -0500
Date: Mon, 24 Nov 2008 22:03:43 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb().
	Fix indentation.
Message-ID: <20081124200343.GB3482@redhat.com>
References: <20081123145248.22178.36228.stgit@dhcp-1-237.tlv.redhat.com>
	<20081123145257.22178.1698.stgit@dhcp-1-237.tlv.redhat.com>
	<492AD6C4.90001@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <492AD6C4.90001@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Nov 24, 2008 at 10:31:00AM -0600, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>> ---
>>
>>  block-qcow2.c |   78 +++++++++++++++++++++++++++++----------------------------
>>  1 files changed, 39 insertions(+), 39 deletions(-)
>>
>> diff --git a/block-qcow2.c b/block-qcow2.c
>> index dc73769..ab19a4e 100644
>> --- a/block-qcow2.c
>> +++ b/block-qcow2.c
>> @@ -1186,7 +1186,7 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>>       acb->hd_aiocb = NULL;
>>      if (ret < 0) {
>> -    fail:
>> +fail:
>>          acb->common.cb(acb->common.opaque, ret);
>>          qemu_aio_release(acb);
>>          return;
>> @@ -1200,8 +1200,8 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>>      } else {
>>          if (s->crypt_method) {
>>              encrypt_sectors(s, acb->sector_num, acb->buf, acb->buf,
>> -                            acb->n, 0,
>> -                            &s->aes_decrypt_key);
>> +                    acb->n, 0,
>> +                    &s->aes_decrypt_key);
>>   
>
> Why did you change this indenting?  There is no tabs and I think it's  
> better the way it is than how you made it.
>
I reformatted the whole function with vi autoindent. I'll drop those two
lines.

--
			Gleb.