From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4hgm-00088w-W0
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:05:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4hgl-00087l-0S
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:05:44 -0500
Received: from [199.232.76.173] (port=56665 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4hgk-00087g-SU
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:05:42 -0500
Received: from mx2.redhat.com ([66.187.237.31]:56365)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1L4hgk-0007jJ-C4
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 15:05:42 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAOK5fQl004123
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 15:05:41 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAOK5fro028785
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 15:05:41 -0500
Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com
	[10.35.1.237])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAOK5eRU001685
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 15:05:40 -0500
Date: Mon, 24 Nov 2008 22:05:58 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/5] Introduce new helper function
	qcow_shedule_bh().
Message-ID: <20081124200558.GC3482@redhat.com>
References: <20081123145248.22178.36228.stgit@dhcp-1-237.tlv.redhat.com>
	<20081123145304.22178.27216.stgit@dhcp-1-237.tlv.redhat.com>
	<492AD735.7030708@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <492AD735.7030708@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Nov 24, 2008 at 10:32:53AM -0600, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Use it to remove code duplications from qcow_aio_read_cb().
>>
>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>> ---
>>
>>  block-qcow2.c |   44 +++++++++++++++++---------------------------
>>  1 files changed, 17 insertions(+), 27 deletions(-)
>>
>> diff --git a/block-qcow2.c b/block-qcow2.c
>> index ab19a4e..69f6414 100644
>> --- a/block-qcow2.c
>> +++ b/block-qcow2.c
>> @@ -1177,6 +1177,20 @@ static void qcow_aio_read_bh(void *opaque)
>>      qcow_aio_read_cb(opaque, 0);
>>  }
>>  +static int qcow_shedule_bh(QEMUBHFunc *cb, QCowAIOCB *acb)
>> +{
>> +    if (acb->bh)
>> +        return -EIO;
>> +
>> +    acb->bh = qemu_bh_new(cb, acb);
>> +    if (!acb->bh)
>> +        return -EIO;
>> +
>> +    qemu_bh_schedule(acb->bh);
>> +
>> +    return 0;
>> +}
>> +
>>  static void qcow_aio_read_cb(void *opaque, int ret)
>>  {
>>      QCowAIOCB *acb = opaque;
>> @@ -1232,30 +1246,14 @@ fail:
>>                  if (acb->hd_aiocb == NULL)
>>                      goto fail;
>>              } else {
>> -                if (acb->bh) {
>> -                    ret = -EIO;
>> -                    goto fail;
>> -                }
>> -                acb->bh = qemu_bh_new(qcow_aio_read_bh, acb);
>> -                if (!acb->bh) {
>> -                    ret = -EIO;
>> +                if((ret = qcow_shedule_bh(qcow_aio_read_bh, acb)) < 0)
>>   
>
> Please do this on two lines and watch the whitespace damage.  Also, you  
OK.

> have a consistent typo in "schedule".
>
That is only one typo and many cut and pastes :)

--
			Gleb.