From: Chris Webb <chris@arachsys.com>
To: Thiemo Seufer <ths@networkno.de>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] Fix off-by-one bug limiting VNC passwords to 7 chars
Date: Tue, 25 Nov 2008 10:09:35 +0000 [thread overview]
Message-ID: <20081125100935.GI2380@arachsys.com> (raw)
In-Reply-To: <20081123123101.GC17042@networkno.de>
Thiemo Seufer <ths@networkno.de> writes:
> Chris Webb wrote:
[...]
> > - monitor_readline("Password: ", 1, password, sizeof(password)-1);
> > + monitor_readline("Password: ", 1, password, sizeof(password));
> > password[sizeof(password)-1] = '\0';
>
> The next line can go as well, the string is already NULL terminated.
You're quite right. I'll update the two patches to reflect this change.
Cheers,
Chris.
next prev parent reply other threads:[~2008-11-25 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 11:31 [Qemu-devel] [PATCH] Fix off-by-one bug limiting VNC passwords to 7 chars Chris Webb
2008-11-23 12:31 ` Thiemo Seufer
2008-11-25 10:09 ` Chris Webb [this message]
2008-11-25 10:25 ` [Qemu-devel] [PATCH v2] " Chris Webb
2008-11-25 10:26 ` [Qemu-devel] [PATCH v2] Accept password as an argument to 'change vnc password' Chris Webb
2008-12-08 14:09 ` [Qemu-devel] [RESEND] " Chris Webb
2008-12-10 15:14 ` [Qemu-devel] " Anthony Liguori
2008-12-08 14:09 ` [Qemu-devel] [RESEND] [PATCH v2] Fix off-by-one bug limiting VNC passwords to 7 chars Chris Webb
2008-12-10 15:14 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125100935.GI2380@arachsys.com \
--to=chris@arachsys.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).