From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L66Vb-0003nU-OY
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 11:47:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L66VZ-0003lC-5V
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 11:47:58 -0500
Received: from [199.232.76.173] (port=46835 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L66VZ-0003l9-0y
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 11:47:57 -0500
Received: from bsdimp.com ([199.45.160.85]:54673 helo=harmony.bsdimp.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <imp@bsdimp.com>) id 1L66VY-00006p-Fj
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 11:47:56 -0500
Date: Fri, 28 Nov 2008 09:46:04 -0700 (MST)
Message-Id: <20081128.094604.420505779.imp@bsdimp.com>
Subject: Re: [Qemu-devel] Re: [PATCH 5/6] qemu fixes
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200811281256.54759.Christoph.Egger@amd.com>
References: <200811281139.07092.Christoph.Egger@amd.com>
	<492FD75E.9040900@siemens.com>
	<200811281256.54759.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Christoph.Egger@amd.com
Cc: blauwirbel@gmail.com, jan.kiszka@siemens.com

In message: <200811281256.54759.Christoph.Egger@amd.com>
            Christoph Egger <Christoph.Egger@amd.com> writes:
: On Friday 28 November 2008 12:34:54 Jan Kiszka wrote:
: > Christoph Egger wrote:
: > > Hi,
: > >
: > > This is a series of four patches which improve support
: > > for qemu on NetBSD.
: > >
: > > sys-queue.h defines _SYS_QUEUE_H_ which is also defined by
: > > the <sys/queue.h> system header. <sys/disk.h> uses SLIST_ENTRY
: > > on NetBSD, which doesn't exist in sys-queue.h. Therefore,
: > > include <sys/queue.h> before including sys-queue.h.
: >
: > Does this patch (which my mail client unfortunately refuses to cite...)
: > take into account that we now have TAILQ_FOREACH_SAFE which NetBSD may
: > lack?
: 
: Yes, NetBSD has it:
: 
: #define TAILQ_FOREACH_SAFE(var, head, field, next)                      \
:         for ((var) = ((head)->tqh_first);                               \
:                 (var) != NULL && ((next) = TAILQ_NEXT(var, field), 1);  \
:                 (var) = (next))
: 
: Another option to this patch would be:
: 
: Renaming _SYS_QUEUE_H_ to QEMU_SYS_QUEUE_H_
: at least allows to include both sys-queue.h and <sys/queue.h>.

That would be the better option, because _XXX is reserved for the
compiler/library/toolchain, not for the application...

Warner