From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L5rFS-0008Pl-Q1 for qemu-devel@nongnu.org; Thu, 27 Nov 2008 19:30:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L5rFR-0008Oa-71 for qemu-devel@nongnu.org; Thu, 27 Nov 2008 19:30:18 -0500 Received: from [199.232.76.173] (port=41284 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5rFQ-0008OR-WF for qemu-devel@nongnu.org; Thu, 27 Nov 2008 19:30:17 -0500 Received: from mx20.gnu.org ([199.232.41.8]:11714) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L5rFO-0006CM-4m for qemu-devel@nongnu.org; Thu, 27 Nov 2008 19:30:16 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L5rFI-0003aE-22 for qemu-devel@nongnu.org; Thu, 27 Nov 2008 19:30:08 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change Date: Fri, 28 Nov 2008 00:29:56 +0000 References: <492D8B94.4000805@eu.citrix.com> <492D9EA4.9050008@eu.citrix.com> <492F3074.6060200@codemonkey.ws> In-Reply-To: <492F3074.6060200@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811280029.57082.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefano Stabellini > >>> - do not use is_active_console, use is_graphic_console instead. > >> > >> This is wrong. There may be multiple graphic consoles. > > > > I thought we wanted to move to a model in which a DisplayState > > corresponds to a single QEMUConsole and a single graphic device. > > This is the reason for Anthony to ask me this update, if I am not > > mistaken. > > I need to look more closely at the patches (and I will tomorrow), but to > me, the use of is_active_console or is_graphics_console is a red > herring. Nothing should never need to know whether it's the "active" > console. Such a concept simply shouldn't exist. > > I think this is Paul's point about multiple graphics consoles. If you > have two graphics consoles, than the concept of active console doesn't > make very much sense. Is that what you were thinking Paul? Something like that, yes. My understanding was that the plan is to have one DisplayState per image source. At that point the device doesn't care whether it's "active" or not (inactive DisplayStates will be the equivalent of /dev/null). If we still have a single DisplayState shared by multiple sources then is_graphics_console is not a sufficient check to tell whether the VGA device is active. I'm not sure that removing QEMUConsole without adding multiple DisplayStates is feasible. Paul