qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5806] qemu-doc.texi: document downscript network option
Date: Fri, 28 Nov 2008 10:26:59 +0000	[thread overview]
Message-ID: <20081128102659.GA6138@shareable.org> (raw)
In-Reply-To: <E1L60Ji-0004BU-Ch@cvs.savannah.gnu.org>

Aurelien Jarno wrote a patch, resulting in:
> @item -net tap[,vlan=@var{n}][,fd=@var{h}][,ifname=@var{name}][,script=@var{file}][,downscript=@var{dfile}]
> Connect the host TAP network interface @var{name} to VLAN @var{n}
> and use the network script @var{file} to configure it. The default
> network script is @file{/etc/qemu-ifup}. Use @option{script=no} to
> disable script execution. If @var{name} is not provided, the OS
> automatically provides one. Use network script @var{dfile} to
> deconfigure the interface. Use @option{downscript=no} to disable
> script execution. @option{fd}=@var{h} can be used to specify the
> handle of an already opened host TAP interface.

Two things don't make sense:

   1. Do you have to write "downscript=no" to disable
      downscript execution?  If you don't need it, that part of the
      documentation is unnecessary.  If you do need it, then it's not
      backward-compatible with earlier QEMU versions.

   2. If you do need "downscript=no" to disable it, what's
      the default downscript name if you don't have "downscript=no"?

Also, it would be better for the text to describe the options in the
same order as the synopsis in the first line, especially describing
the two script options without anything else between.

-- Jamie

  reply	other threads:[~2008-11-28 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-28 10:11 [Qemu-devel] [5806] qemu-doc.texi: document downscript network option Aurelien Jarno
2008-11-28 10:26 ` Jamie Lokier [this message]
2008-11-28 11:18   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081128102659.GA6138@shareable.org \
    --to=jamie@shareable.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).