From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L60Z9-0005nl-Hx
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:27:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L60Z5-0005il-7B
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:27:14 -0500
Received: from [199.232.76.173] (port=36353 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L60Z4-0005ic-VF
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:27:11 -0500
Received: from mail2.shareable.org ([80.68.89.115]:60667)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1L60Z3-0004H0-Vb
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:27:10 -0500
Received: from jamie by mail2.shareable.org with local (Exim 4.63)
	(envelope-from <jamie@shareable.org>) id 1L60Yt-0001cJ-FQ
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 10:26:59 +0000
Date: Fri, 28 Nov 2008 10:26:59 +0000
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [5806] qemu-doc.texi: document downscript network
	option
Message-ID: <20081128102659.GA6138@shareable.org>
References: <E1L60Ji-0004BU-Ch@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1L60Ji-0004BU-Ch@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Aurelien Jarno wrote a patch, resulting in:
> @item -net tap[,vlan=@var{n}][,fd=@var{h}][,ifname=@var{name}][,script=@var{file}][,downscript=@var{dfile}]
> Connect the host TAP network interface @var{name} to VLAN @var{n}
> and use the network script @var{file} to configure it. The default
> network script is @file{/etc/qemu-ifup}. Use @option{script=no} to
> disable script execution. If @var{name} is not provided, the OS
> automatically provides one. Use network script @var{dfile} to
> deconfigure the interface. Use @option{downscript=no} to disable
> script execution. @option{fd}=@var{h} can be used to specify the
> handle of an already opened host TAP interface.

Two things don't make sense:

   1. Do you have to write "downscript=no" to disable
      downscript execution?  If you don't need it, that part of the
      documentation is unnecessary.  If you do need it, then it's not
      backward-compatible with earlier QEMU versions.

   2. If you do need "downscript=no" to disable it, what's
      the default downscript name if you don't have "downscript=no"?

Also, it would be better for the text to describe the options in the
same order as the synopsis in the first line, especially describing
the two script options without anything else between.

-- Jamie