From: Thiemo Seufer <ths@networkno.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute
Date: Fri, 28 Nov 2008 19:28:59 +0100 [thread overview]
Message-ID: <20081128182859.GA20428@networkno.de> (raw)
In-Reply-To: <493030EA.4040405@web.de>
Jan Kiszka wrote:
> malc wrote:
> > On Fri, 28 Nov 2008, Jan Kiszka wrote:
> >
> >> Introduce __noreturn attribute and attach it to cpu_loop_exit as well as
> >> interrupt/exception helpers for i386. This avoids a bunch of gcc4
> >> warnings.
> >
> > ISO/IEC 9899:1990
> >
> > 7.1.3
> > -- All identifiers that begin with an underscore and
> > either an uppercase letter or another underscore are
> > always reserved for any use.
>
> ...but commonly used in practice (which is no excuse to do so here, just
> an explanation). Given that we have __hidden already, I just followed
> the existing pattern.
A kernel is free to make its own rules about namespaces, but userland
applications like Qemu should adhere to the userland standards.
Thiemo
next prev parent reply other threads:[~2008-11-28 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 11:47 [Qemu-devel] [PATCH 2/2] Add __noreturn function attribute Jan Kiszka
2008-11-28 17:35 ` malc
2008-11-28 17:56 ` [Qemu-devel] " Jan Kiszka
2008-11-28 18:28 ` Thiemo Seufer [this message]
2008-11-30 10:08 ` Avi Kivity
2008-11-30 11:51 ` Stefan Weil
2008-11-30 12:00 ` Laurent Desnogues
2008-11-30 12:38 ` Jan Kiszka
2008-11-30 12:52 ` Stefan Weil
2008-11-30 13:37 ` Andreas Färber
2008-11-30 17:21 ` M. Warner Losh
2008-11-30 12:33 ` Jan Kiszka
2008-11-30 13:11 ` Thiemo Seufer
2008-11-30 14:36 ` Jan Kiszka
2008-12-02 19:49 ` Anthony Liguori
2008-12-04 16:44 ` Jan Kiszka
2008-12-04 18:39 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128182859.GA20428@networkno.de \
--to=ths@networkno.de \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).