From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L694v-0004G4-5Z
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 14:32:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L694t-0004Du-2K
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 14:32:36 -0500
Received: from [199.232.76.173] (port=57677 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L694s-0004Dm-RX
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 14:32:34 -0500
Received: from relay01.mx.bawue.net ([193.7.176.67]:46538)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1L694s-0005sJ-9b
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 14:32:34 -0500
Received: from lagash (p549AF576.dip.t-dialin.net [84.154.245.118])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by relay01.mx.bawue.net (Postfix) with ESMTP id 9DF28481A8
	for <qemu-devel@nongnu.org>; Fri, 28 Nov 2008 20:32:32 +0100 (CET)
Received: from ths by lagash with local (Exim 4.69)
	(envelope-from <ths@networkno.de>) id 1L694p-0005gX-Lf
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 20:32:31 +0100
Date: Fri, 28 Nov 2008 20:32:31 +0100
From: Thiemo Seufer <ths@networkno.de>
Message-ID: <20081128193231.GA20624@networkno.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] Bugs in ppc TCG backend
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hello All,

since Revision 5729 I see failures with my usual set of mips regression
tests. The breakage is limited to the ppc TCG backend, apparently r5729
triggers bugs there.

The problem should be reproducible when attempting to install Debian
mipsel. The symptom is a segfault of qemu-system-mipsel after selecting
the country. For qemu-system-mips64el, the segfault happens much
earlier after only a few instructions.

I think I found one alignment bug, applying the appended patch moves
the crash in qemu-system-mips64el to a later point.


Thiemo


Index: qemu-work/tcg/tcg.c
===================================================================
--- qemu-work.orig/tcg/tcg.c	2008-11-27 19:47:42.000000000 +0100
+++ qemu-work/tcg/tcg.c	2008-11-28 19:24:42.000000000 +0100
@@ -621,7 +621,7 @@
 #endif
 #ifdef TCG_TARGET_CALL_ALIGN_ARGS
             /* some targets want aligned 64 bit args */
-            if (i & 1) {
+            if ((i & 1) && !(sizemask & (2 << (i - 1)))) {
                 *gen_opparam_ptr++ = TCG_CALL_DUMMY_ARG;
             }
 #endif