From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Some fixes for TCG debugging
Date: Sat, 29 Nov 2008 16:47:57 +0000 [thread overview]
Message-ID: <200811291647.57683.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580811290826g5263c363lbea4175c4cfa1517@mail.gmail.com>
On Saturday 29 November 2008, Blue Swirl wrote:
> On 11/29/08, Laurent Desnogues <laurent.desnogues@gmail.com> wrote:
> > On Thu, Nov 20, 2008 at 1:11 PM, Laurent Desnogues
> >
> > <laurent.desnogues@gmail.com> wrote:
> > > On Tue, Nov 18, 2008 at 4:02 PM, Laurent Desnogues
> > >
> > > <laurent.desnogues@gmail.com> wrote:
> > >> Hello,
> > >>
> > >> this fixes a few things after Paul's improvements for TCG debugging:
> > >>
> > >> - change TCGv_i64 field name to something different from
> > >> TCGv_i32
> > >> - fix things in tcg that the above change made visible.
> > >
> > > No comment about that patch? Except that it lacks this:
> > >
> > > Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> >
> > Still no comment for something that obvious?
>
> Looks OK. Anybody mind if I apply this?
IMHO it would make sense to call them i32/i64, thather than i/i2.
Paul
next prev parent reply other threads:[~2008-11-29 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 15:02 [Qemu-devel] [PATCH] Some fixes for TCG debugging Laurent Desnogues
2008-11-20 12:11 ` [Qemu-devel] " Laurent Desnogues
2008-11-29 15:49 ` Laurent Desnogues
2008-11-29 16:26 ` Blue Swirl
2008-11-29 16:47 ` Paul Brook [this message]
2008-11-29 16:57 ` Laurent Desnogues
2008-12-07 16:35 ` Laurent Desnogues
2008-12-07 17:13 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811291647.57683.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).