From: Thiemo Seufer <ths@networkno.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute
Date: Sun, 30 Nov 2008 14:11:07 +0100 [thread overview]
Message-ID: <20081130131107.GA28482@networkno.de> (raw)
In-Reply-To: <49328833.3000605@web.de>
Jan Kiszka wrote:
> Avi Kivity wrote:
> > Jan Kiszka wrote:
> >>> Breaking the standard is what brings us the joys of recently (re)posted
> >>> patch for NetBSD and [u]intXX fun.
> >>>
> >>
> >> I have no problem with calling it 'noreturn' instead.
> >>
> >
> > That will break code that wants to use 'noreturn' as a local variable.
> > I think ATTR_NORETURN, while a lot uglier, is safer.
>
> Do you have such code already? Is it exported beyond qemu scope? Then
> why not going for our own convention "'noreturn' is reserved as function
> attribute"? (And yes, your macro is ugly :) ).
"Macro names should be in upper case" is also a useful convention.
FWIW, I agree with Stefan, there's currently not much need to isolate
gcc-isms.
Thiemo
next prev parent reply other threads:[~2008-11-30 13:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 11:47 [Qemu-devel] [PATCH 2/2] Add __noreturn function attribute Jan Kiszka
2008-11-28 17:35 ` malc
2008-11-28 17:56 ` [Qemu-devel] " Jan Kiszka
2008-11-28 18:28 ` Thiemo Seufer
2008-11-30 10:08 ` Avi Kivity
2008-11-30 11:51 ` Stefan Weil
2008-11-30 12:00 ` Laurent Desnogues
2008-11-30 12:38 ` Jan Kiszka
2008-11-30 12:52 ` Stefan Weil
2008-11-30 13:37 ` Andreas Färber
2008-11-30 17:21 ` M. Warner Losh
2008-11-30 12:33 ` Jan Kiszka
2008-11-30 13:11 ` Thiemo Seufer [this message]
2008-11-30 14:36 ` Jan Kiszka
2008-12-02 19:49 ` Anthony Liguori
2008-12-04 16:44 ` Jan Kiszka
2008-12-04 18:39 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081130131107.GA28482@networkno.de \
--to=ths@networkno.de \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).