From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] MMIO address changes
Date: Mon, 1 Dec 2008 18:59:35 +0000 [thread overview]
Message-ID: <200812011859.35859.paul@codesourcery.com> (raw)
I've just committed a patch that changes the MMIO callback interface for
devices. Instead of being passed an absolute address these are now passed an
offset from the start[1] of the memory region that was registered.
By itself this change has fairly neutral benefit, it just moves logic about.
However it makes subsequent dynamic board configuration bits nicer, and is a
step towards a proper bus level API.
Most of the groundwork for this is already there, from my earlier changes to
separate ram and MMIO addresses TLB handling.
The main notable change it that the PhysPageDesc structure is not bigger. This
isn't ideal, however l2_phys_map needs to go away anyway, so I'm not really
worried about this.
Some devices register their memory regions in multiple segments. To facilitate
this I have added cpu_register_physical_memory_offset.
Most of the remaining changes are fairly mechanical tweaks to fix devices that
explicitly compensated for the absolute address. Many devices are untouched
because they ignore the high bits of the address.
I've tried to be fairly thorough with the changes, and tested what I can.
However it's possible I missed or broke something, so please test your
favourite targets.
Paul
[1] It's actually the offset from the start of the first page of that region.
In practice this difference doesn't matter, and makes the implementation a
lot simpler.
next reply other threads:[~2008-12-01 18:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 18:59 Paul Brook [this message]
2008-12-02 16:47 ` [Qemu-devel] MMIO address changes takasi-y
2008-12-02 17:09 ` Paul Brook
2008-12-02 17:10 ` Paul Brook
2008-12-03 14:37 ` [Qemu-devel] [PATCH] sh4: Followup to commit #5849 "Change MMIO callbacks..." takasi-y
2008-12-10 17:44 ` [Qemu-devel] " Vladimir Prus
2008-12-14 16:54 ` takasi-y
2008-12-03 12:17 ` [Qemu-devel] MMIO address changes Edgar E. Iglesias
2008-12-03 14:03 ` Paul Brook
2008-12-07 20:24 ` Edgar E. Iglesias
2009-01-07 15:39 ` Edgar E. Iglesias
2008-12-05 13:52 ` [Qemu-devel] [PATCH] usb-ohci: Add address masking takasi-y
2008-12-07 16:05 ` andrzej zaborowski
2008-12-08 13:04 ` Paul Brook
2008-12-08 10:15 ` Thomas Bandelier
2008-12-09 15:21 ` takasi-y
2008-12-11 8:55 ` [Qemu-devel] Re: MMIO address changes Vladimir Prus
2008-12-25 22:33 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812011859.35859.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).