From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L7Ym6-0005Sq-Ly
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 12:11:02 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L7Ym6-0005Sb-5a
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 12:11:02 -0500
Received: from [199.232.76.173] (port=60551 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L7Ym5-0005SY-UU
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 12:11:02 -0500
Received: from mx20.gnu.org ([199.232.41.8]:14738)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1L7Ym5-0004IK-NR
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 12:11:01 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1L7Ym4-0004sY-Sx
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 12:11:01 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] MMIO address changes
Date: Tue, 2 Dec 2008 17:10:44 +0000
References: <200812011859.35859.paul@codesourcery.com>
	<200812021647.mB2Gldoe003402@smtp11.dti.ne.jp>
In-Reply-To: <200812021647.mB2Gldoe003402@smtp11.dti.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200812021710.45302.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: takasi-y@ops.dti.ne.jp
Cc: qemu-devel@nongnu.org

> Now, at least hw/sm501.c has been already broken by this case.
> It registers palette register array at
>  base + MMIO_BASE_OFFSET + SM501_DC + SM501_DC_PANEL_PALETTE,
>  = 0x10000000 + 0x3e00000 + 0x080000 + 0x400
> so, palette index offsets 0x400.
>
> Of cource I can fix it by
>  addr -= (MMIO_BASE_OFFSET + SM501_DC +
> SM501_DC_PANEL_PALETTE)&~TARGET_PAGE_MASK; before accessing the register.
> Looks not so smart...
> Are there any idea?

Proably simpler to just use a single region for both.

Paul