From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L936T-0008QY-M2 for qemu-devel@nongnu.org; Sat, 06 Dec 2008 14:46:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L936S-0008QC-D7 for qemu-devel@nongnu.org; Sat, 06 Dec 2008 14:46:13 -0500 Received: from [199.232.76.173] (port=54305 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L936S-0008Q0-7q for qemu-devel@nongnu.org; Sat, 06 Dec 2008 14:46:12 -0500 Received: from bart.se.axis.com ([195.60.68.10]:33922) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L936R-0003TX-Oh for qemu-devel@nongnu.org; Sat, 06 Dec 2008 14:46:11 -0500 Received: from bart.se.axis.com (bart.se.axis.com [127.0.0.1]) by bart.se.axis.com (Postfix) with ESMTP id 662466424E for ; Sat, 6 Dec 2008 20:46:10 +0100 (CET) Received: from axis.com (edgar.se.axis.com [10.93.151.1]) by bart.se.axis.com (Postfix) with ESMTP id 481486424A for ; Sat, 6 Dec 2008 20:46:10 +0100 (CET) Date: Sat, 6 Dec 2008 20:46:10 +0100 From: "Edgar E. Iglesias" Subject: Re: [Qemu-devel] [PATCH] mmap: add check if requested memory area fits target address space Message-ID: <20081206194610.GA1167@edgar.se.axis.com> References: <1228303789-25653-1-git-send-email-kirill@shutemov.name> <1228303789-25653-2-git-send-email-kirill@shutemov.name> <1228303789-25653-3-git-send-email-kirill@shutemov.name> <1228303789-25653-4-git-send-email-kirill@shutemov.name> <1228303789-25653-5-git-send-email-kirill@shutemov.name> <1228303789-25653-6-git-send-email-kirill@shutemov.name> <1228303789-25653-7-git-send-email-kirill@shutemov.name> <1228303789-25653-8-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1228303789-25653-8-git-send-email-kirill@shutemov.name> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Kirill A. Shutemov" On Wed, Dec 03, 2008 at 01:29:43PM +0200, Kirill A. Shutemov wrote: > Signed-off-by: Kirill A. Shutemov > --- > linux-user/mmap.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/linux-user/mmap.c b/linux-user/mmap.c > index d96917d..52e2dc8 100644 > --- a/linux-user/mmap.c > +++ b/linux-user/mmap.c > @@ -389,6 +389,16 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot, > end = start + len; > real_end = HOST_PAGE_ALIGN(end); > > + /* > + * Test if requested memory area fits target address space > + * It can fail only on 64-bit host with 32-bit target. > + * On any other target/host host mmap() handles this error correctly. > + */ > + if ((unsigned long)start + len - 1 > (abi_ulong) -1) { > + errno = EINVAL; > + goto fail; > + } > + > for(addr = real_start; addr < real_end; addr += TARGET_PAGE_SIZE) { > flg = page_get_flags(addr); > if (flg & PAGE_RESERVED) { Acked-by: Edgar E. Iglesias