From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L9Fo7-0004JF-QN for qemu-devel@nongnu.org; Sun, 07 Dec 2008 04:20:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L9Fo6-0004It-C0 for qemu-devel@nongnu.org; Sun, 07 Dec 2008 04:20:06 -0500 Received: from [199.232.76.173] (port=40871 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L9Fo6-0004Iq-5E for qemu-devel@nongnu.org; Sun, 07 Dec 2008 04:20:06 -0500 Received: from mx2.redhat.com ([66.187.237.31]:46950) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L9Fo5-0001ZB-Ov for qemu-devel@nongnu.org; Sun, 07 Dec 2008 04:20:06 -0500 Date: Sun, 7 Dec 2008 11:20:31 +0200 From: Gleb Natapov Message-ID: <20081207092031.GA32185@redhat.com> References: <20081127110220.25353.83454.stgit@dhcp-1-237.tlv.redhat.com> <20081127110225.25353.57932.stgit@dhcp-1-237.tlv.redhat.com> <20081207025738.GA27991@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081207025738.GA27991@morn.localdomain> Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v5 1/5] Add S3 state to DSDT. Handle resume event in the BIOS. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org On Sat, Dec 06, 2008 at 09:57:38PM -0500, Kevin O'Connor wrote: > Hi Gleb, > > On Thu, Nov 27, 2008 at 01:02:25PM +0200, Gleb Natapov wrote: > [...] > > @@ -10375,6 +10420,12 @@ normal_post: > > mov ds, ax > > mov ss, ax > > > > + ;; Save shutdown status > > + mov 0x04b0, bl > > + > > + cmp bl, #0xfe > > + jz s3_post > > + > > What sets 40:b0 to 0xfe on a resume? > Qemu/Bochs. > Also, wouldn't this corrupt memory used by the stack (the stack gets > set to 0xfffe, and s3_post has call insns in it)? > Oh. I thought it was set to be at the top of the first page, but it has one extra 'f' :( We should change it to be 0xffe instead. -- Gleb.