From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar@axis.com>, pbrook@codesourcery.com
Subject: Re: [Qemu-devel] MMIO address changes
Date: Sun, 7 Dec 2008 21:24:21 +0100 [thread overview]
Message-ID: <20081207202421.GF1167@edgar.se.axis.com> (raw)
In-Reply-To: <200812031403.54060.paul@codesourcery.com>
On Wed, Dec 03, 2008 at 02:03:53PM +0000, Paul Brook wrote:
> > > I've tried to be fairly thorough with the changes, and tested what I can.
> > > However it's possible I missed or broke something, so please test your
> > > favourite targets.
> >
> > FWIW the etrax-fs machine works OK although I am seeing a noticeable
> > slow-down after the patch.
>
> Strange. I wouldn't expect significant slowdown.
> AFAIK the hot-path code should be pretty much unchanged (if anything faster
> because the IO handlers don't need to adjust the address). Even the TLB fill
> handler overhead (tlb_set_page_exec) should be negligible.
Hello Paul,
I went through your patch and AFAICT it looks fine. The only thing I saw
that may cause slowdowns was the size increase of PageDesc and subpage.
In case anybody want's to reproduce this, just start the etrax image I've
posted before, login trough telnet and do a ls -alR /, you'll see a very
noticeable difference.
Best regards
Edgar
next prev parent reply other threads:[~2008-12-07 20:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 18:59 [Qemu-devel] MMIO address changes Paul Brook
2008-12-02 16:47 ` takasi-y
2008-12-02 17:09 ` Paul Brook
2008-12-02 17:10 ` Paul Brook
2008-12-03 14:37 ` [Qemu-devel] [PATCH] sh4: Followup to commit #5849 "Change MMIO callbacks..." takasi-y
2008-12-10 17:44 ` [Qemu-devel] " Vladimir Prus
2008-12-14 16:54 ` takasi-y
2008-12-03 12:17 ` [Qemu-devel] MMIO address changes Edgar E. Iglesias
2008-12-03 14:03 ` Paul Brook
2008-12-07 20:24 ` Edgar E. Iglesias [this message]
2009-01-07 15:39 ` Edgar E. Iglesias
2008-12-05 13:52 ` [Qemu-devel] [PATCH] usb-ohci: Add address masking takasi-y
2008-12-07 16:05 ` andrzej zaborowski
2008-12-08 13:04 ` Paul Brook
2008-12-08 10:15 ` Thomas Bandelier
2008-12-09 15:21 ` takasi-y
2008-12-11 8:55 ` [Qemu-devel] Re: MMIO address changes Vladimir Prus
2008-12-25 22:33 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081207202421.GF1167@edgar.se.axis.com \
--to=edgar.iglesias@axis.com \
--cc=edgar@axis.com \
--cc=pbrook@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).