Re: [Qemu-devel] [PATCH] SH4: SCI improvement

[Aurelien Jarno <aurelien@aurel32.net>]

On Sun, Nov 23, 2008 at 11:41:25PM +0900, Shin-ichiro KAWASAKI wrote:
> This patch simply implement one register of SH4's SCI := Serial Communication Interface.
> 
> R2D evaluation board uses SCI for SPI connection.  So, Linux kernel for R2D with
> default configuration causes a QEMU assertion failure when it initializes SPI driver.
> This patch avoids it and reduces the kernel config modification work for QEMU.
> 
> Completing SCI implementation task is left.  Other board support is desirable to confirm
> this task, which uses SCI for a serial terminal.
> 
> Regards,
> Shin-ichiro KAWASAKI
 
Thanks, applied.

> Signed-off-by: Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>
> 
> Index: trunk/hw/sh_serial.c
> ===================================================================
> --- trunk/hw/sh_serial.c	(revision 5771)
> +++ trunk/hw/sh_serial.c	(working copy)
> @@ -168,19 +168,19 @@
>          }
>      }
>      else {
> +        switch(offs) {
>  #if 0
> -        switch(offs) {
>          case 0x0c:
>              ret = s->dr;
>              break;
>          case 0x10:
>              ret = 0;
>              break;
> +#endif
>          case 0x1c:
> -            ret = s->sptr;
> -            break;
> +            s->sptr = val & 0x8f;
> +            return;
>          }
> -#endif
>      }
>  
>      fprintf(stderr, "sh_serial: unsupported write to 0x%02x\n", offs);
> @@ -260,8 +260,8 @@
>          }
>      }
>      else {
> +        switch(offs) {
>  #if 0
> -        switch(offs) {
>          case 0x0c:
>              ret = s->dr;
>              break;
> @@ -271,11 +271,11 @@
>          case 0x14:
>              ret = s->rx_fifo[0];
>              break;
> +#endif
>          case 0x1c:
>              ret = s->sptr;
>              break;
>          }
> -#endif
>      }
>  #ifdef DEBUG_SERIAL
>      printf("sh_serial: read base=0x%08lx offs=0x%02x val=0x%x\n",
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net