From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L9SOq-0007s1-AX
	for qemu-devel@nongnu.org; Sun, 07 Dec 2008 17:46:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L9SOp-0007rR-O6
	for qemu-devel@nongnu.org; Sun, 07 Dec 2008 17:46:51 -0500
Received: from [199.232.76.173] (port=43744 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L9SOp-0007rM-Eb
	for qemu-devel@nongnu.org; Sun, 07 Dec 2008 17:46:51 -0500
Received: from hall.aurel32.net ([88.191.82.174]:55225)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1L9SOo-0002Sl-Mh
	for qemu-devel@nongnu.org; Sun, 07 Dec 2008 17:46:51 -0500
Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b])
	by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <aurelien@aurel32.net>)
	id 1L9SOn-0007rZ-3K
	for qemu-devel@nongnu.org; Sun, 07 Dec 2008 23:46:49 +0100
Received: from aurel32 by volta.aurel32.net with local (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1L9SOm-0000VR-Iw
	for qemu-devel@nongnu.org; Sun, 07 Dec 2008 23:46:48 +0100
Date: Sun, 7 Dec 2008 23:46:48 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] SH4: SCI improvement
Message-ID: <20081207224648.GC3591@volta.aurel32.net>
References: <49296B95.4020707@juno.dti.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <49296B95.4020707@juno.dti.ne.jp>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Nov 23, 2008 at 11:41:25PM +0900, Shin-ichiro KAWASAKI wrote:
> This patch simply implement one register of SH4's SCI := Serial Communication Interface.
> 
> R2D evaluation board uses SCI for SPI connection.  So, Linux kernel for R2D with
> default configuration causes a QEMU assertion failure when it initializes SPI driver.
> This patch avoids it and reduces the kernel config modification work for QEMU.
> 
> Completing SCI implementation task is left.  Other board support is desirable to confirm
> this task, which uses SCI for a serial terminal.
> 
> Regards,
> Shin-ichiro KAWASAKI
 
Thanks, applied.

> Signed-off-by: Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>
> 
> Index: trunk/hw/sh_serial.c
> ===================================================================
> --- trunk/hw/sh_serial.c	(revision 5771)
> +++ trunk/hw/sh_serial.c	(working copy)
> @@ -168,19 +168,19 @@
>          }
>      }
>      else {
> +        switch(offs) {
>  #if 0
> -        switch(offs) {
>          case 0x0c:
>              ret = s->dr;
>              break;
>          case 0x10:
>              ret = 0;
>              break;
> +#endif
>          case 0x1c:
> -            ret = s->sptr;
> -            break;
> +            s->sptr = val & 0x8f;
> +            return;
>          }
> -#endif
>      }
>  
>      fprintf(stderr, "sh_serial: unsupported write to 0x%02x\n", offs);
> @@ -260,8 +260,8 @@
>          }
>      }
>      else {
> +        switch(offs) {
>  #if 0
> -        switch(offs) {
>          case 0x0c:
>              ret = s->dr;
>              break;
> @@ -271,11 +271,11 @@
>          case 0x14:
>              ret = s->rx_fifo[0];
>              break;
> +#endif
>          case 0x1c:
>              ret = s->sptr;
>              break;
>          }
> -#endif
>      }
>  #ifdef DEBUG_SERIAL
>      printf("sh_serial: read base=0x%08lx offs=0x%02x val=0x%x\n",
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net