From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND][PATCH] Fix memory-mapped i8042 on MIPS Magnum
Date: Mon, 8 Dec 2008 16:28:50 +0100 [thread overview]
Message-ID: <20081208152850.GA14780@volta.aurel32.net> (raw)
In-Reply-To: <493C3902.4010105@reactos.org>
On Sun, Dec 07, 2008 at 09:58:42PM +0100, Hervé Poussineau wrote:
> Hi,
Hi!
> Current implementation of memory-mapped i8042 controller is atm
> implemented with an interface shift (it_shift) parameter, like most all
> memory-mapped devices in Qemu.
> However, this isn't suitable for MIPS Magnum, where i8042 controller is
> at 0x80005000 up to 0x80005fff.
>
> Thomas Bogendoerfer (from #mipslinux) tested the behaviour of a real
> machine, and found that odd addresses are for status/command register,
> and even addresses for data register.
>
> Attached patch implements this behaviour by replacing the it_shift
> parameter by a mask one.
> Incidentally, keyboard now works on OpenBSD 2.3, which accesses i8042
> controller at 0x80005060 and 0x80005061.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>
> Changes since v1:
> - updated to qemu svn
It looks basically ok, except that the size and the address should be
of type target_phys_addr_t instead of ram_addr_t.
Aurelien
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-12-08 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 20:58 [Qemu-devel] [RESEND][PATCH] Fix memory-mapped i8042 on MIPS Magnum Hervé Poussineau
2008-12-08 15:28 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208152850.GA14780@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).