From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L9l3d-0003gJ-QV for qemu-devel@nongnu.org; Mon, 08 Dec 2008 13:42:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L9l3c-0003fG-3z for qemu-devel@nongnu.org; Mon, 08 Dec 2008 13:42:13 -0500 Received: from [199.232.76.173] (port=57577 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L9l3b-0003ez-Rb for qemu-devel@nongnu.org; Mon, 08 Dec 2008 13:42:11 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:50232) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L9l3b-0006Xe-Eo for qemu-devel@nongnu.org; Mon, 08 Dec 2008 13:42:11 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB8IfIPY029442 for ; Mon, 8 Dec 2008 11:41:18 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB8Ig1ZN226162 for ; Mon, 8 Dec 2008 11:42:01 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB8Ig0rO011424 for ; Mon, 8 Dec 2008 11:42:00 -0700 Date: Mon, 8 Dec 2008 12:41:59 -0600 From: Ryan Harper Subject: Re: [Qemu-devel] [PATCH 3/4] LSI53C895A: Implement TARGET RESET message Message-ID: <20081208184159.GK13481@us.ibm.com> References: <1228759670-31113-1-git-send-email-ryanh@us.ibm.com> <1228759670-31113-4-git-send-email-ryanh@us.ibm.com> <200812081838.23464.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200812081838.23464.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Ryan Harper , qemu-devel@nongnu.org, kvm@vger.kernel.org * Paul Brook [2008-12-08 12:40]: > On Monday 08 December 2008, Ryan Harper wrote: > > Linux and Windows send a TARGET RESET message to the device when it fails > > to respond as it expects. For example, when it tries to select LUN1, which > > we don't support. This patch is needed to support the Linux sym53c8xx_2 > > driver when configured with SYM_CONF_DMA_ADDRESSING_MODE=2 > > > > Signed-off-by: Ryan Harper > > > > diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c > > index b36c08c..ac8c5a5 100644 > > --- a/hw/lsi53c895a.c > > +++ b/hw/lsi53c895a.c > > @@ -804,6 +804,10 @@ static void lsi_do_msgout(LSIState *s) > > goto bad; > > } > > break; > > + case 0x0c: /* TARGET RESET */ > > + DPRINTF("MSG: Target Reset\n"); > > + lsi_soft_reset(s); > > + break; > > case 0x20: /* SIMPLE queue */ > > s->current_tag |= lsi_get_msgbyte(s) | LSI_TAG_VALID; > > DPRINTF("SIMPLE queue tag=0x%x\n", s->current_tag & 0xff); > > This looks wrong. The clue is in the name. This should reset the *target* > device (i.e. the disk) not the host adapter. > > Probably also explains why you need the bogus 4th patch. Hrm, indeed. Lemme drop the reset and quirk patch and test that mode again on linux. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com