From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LA2mt-0008V3-36
	for qemu-devel@nongnu.org; Tue, 09 Dec 2008 08:38:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LA2mr-0008UJ-LC
	for qemu-devel@nongnu.org; Tue, 09 Dec 2008 08:38:06 -0500
Received: from [199.232.76.173] (port=42525 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LA2mr-0008UF-FK
	for qemu-devel@nongnu.org; Tue, 09 Dec 2008 08:38:05 -0500
Received: from mx2.redhat.com ([66.187.237.31]:39170)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1LA2mr-0000oe-DT
	for qemu-devel@nongnu.org; Tue, 09 Dec 2008 08:38:05 -0500
Date: Tue, 9 Dec 2008 15:38:45 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20081209133844.GA5555@redhat.com>
References: <20081127110220.25353.83454.stgit@dhcp-1-237.tlv.redhat.com>
	<20081127110225.25353.57932.stgit@dhcp-1-237.tlv.redhat.com>
	<20081207025738.GA27991@morn.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081207025738.GA27991@morn.localdomain>
Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH v5 1/5] Add S3 state to
	DSDT. Handle resume event in the BIOS.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: bochs-developers@lists.sourceforge.net
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org

On Sat, Dec 06, 2008 at 09:57:38PM -0500, Kevin O'Connor wrote:
> Also, wouldn't this corrupt memory used by the stack (the stack gets
> set to 0xfffe, and s3_post has call insns in it)?
Here is the patch to set stack pointer to a different value on S3 resume:

Signed-off-by: Gleb Natapov <gleb@redhat.com>

diff --git a/bios/rombios.c b/bios/rombios.c
index 7a9c1fd..8e1d3ec 100644
--- a/bios/rombios.c
+++ b/bios/rombios.c
@@ -9114,6 +9114,7 @@ retf_post_0x467:
   retf
 
 s3_post:
+  mov sp, #0xffe
 #if BX_ROMBIOS32
   call rombios32_init
 #endif
--
			Gleb.